You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "spuru9 (via GitHub)" <gi...@apache.org> on 2026/09/20 19:01:26 UTC
[PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
spuru9 opened a new pull request, #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228
## What is the purpose of the change
Routine CI-matrix currency pass, split by workflow:
- `push_pr.yml`: test PRs against JDK 17 **and 21** (flink-connector-kafka already tests 11/17/21 via the same reusable `apache/flink-connector-shared-utils` workflow, so this is mechanical parity, not new capability), and against the currently relevant Flink minor lines (`2.1.3`, `2.2.1`, `2.3.0`).
- `weekly.yml`: give the actively-developed `main` line the broadened JDK matrix by defaulting to `'17, 21'` (matching flink-connector-kafka's convention of testing `main` broadly while pinning release lines to a single JDK to stay under the ASF's 20-concurrent-job limit); fixes `main`'s `flink_branches` entry, which was pinned to the stale `2.2-SNAPSHOT` even though `apache/flink`'s actual `master` now builds `2.4-SNAPSHOT`; `v4.1` is now tested against both `2.3.0` and `2.2.1`; `v3.4` bumped to the latest `1.20.x` patch (`1.20.5`).
- `pom.xml`: bump `flink.version` from `2.0.0` to `2.1.2` so the connector's actual declared build target matches what the CI matrix now tests, instead of trailing behind it.
## Brief change log
- Bump `push_pr.yml` `jdk` matrix from `['17']` to `['17, 21']`
- Bump `push_pr.yml` `flink` matrix from `[2.0.1, 2.1.1]` to `[2.1.3, 2.2.1, 2.3.0]`
- Fix `weekly.yml` `main` entry's Flink version: `2.2-SNAPSHOT` -> `2.4-SNAPSHOT`
- Default `weekly.yml` `jdk_version` fallback to `'17, 21'` (used by `main`)
- Add a `v4.1` / `2.3.0` entry to `weekly.yml`, alongside the existing `v4.1` / `2.2.1` entry
- Bump `weekly.yml` `v3.4` Flink patch from `1.20.3` to `1.20.5`
- Bump `pom.xml` `flink.version` from `2.0.0` to `2.1.2`
## Verifying this change
- Full reactor compile (`flink-connector-jdbc-core` + dependents) succeeds against `flink.version=2.1.2`.
- `push_pr.yml` and `weekly.yml` validated as well-formed YAML.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes (`flink.version` 2.0.0 -> 2.1.2)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (Claude Code)
Generated-by: Claude Code (claude-sonnet-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057791660
##########
pom.xml:
##########
@@ -56,7 +56,7 @@ under the License.
</modules>
<properties>
- <flink.version>2.0.0</flink.version>
+ <flink.version>2.1.2</flink.version>
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>2.12.7</scala-library.version>
<jackson-bom.version>2.13.4.20221013</jackson-bom.version>
Review Comment:
should we bump other dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057811902
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Didnt want to run a lot of lefts given it already increases 6 to 9. Will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057899711
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Will make the change.
Moving to draft, will run some more CI checks locally over all combinations once more before opening the PR. Seems like java 21 is not fully compatible with the tests right now.
To catch java21 issues I would like to keep 21 in the latest, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5752919520
Have created FLINK-40725 to track the failure in jdbcDynamicTableSinkITCase.testReadingFromChangelogSource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057790688
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
why do we need jdk17 here if default is 17, 21?
i would expect no jdk field here at all, then it will be built for both 17 and 21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5752470407
@spuru9 this should help with jdk21 dependencies in tests btw https://github.com/apache/flink-connector-jdbc/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057899711
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Will make the change.
Moving to draft, will run some more CI checks locally over all combinations once more before opening the PR. Seems like java 21 is not fully compatible with the tests right now.
To catch such issues I would like to keep 21 in the latest to catch at PR build, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4058069051
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Done 1/version. Kept 21 for main, to check spanning 8 → 17 → 21.
My only concern is to avoid any flakiness that comes with 21 tests, which we can see in this weekly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5752648836
Rebased post #230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057899711
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Will make the change.
Moving to draft, will run some more CI checks locally over all combinations once more before opening the PR. Seems like java 21 is not fully compatible with the tests right now.
To catch such issues I would like to keep 21 in the latest, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4058010944
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
If I understand it correctly
Have moved the 1.20 to just 8. and other older 2.x are just 17.
For the latest it would be nice to test across a couple version so kept it at 11, 17, 21 (similar to kafka)
The total count remains the name (6)
Have kept PR for 2.1.x up given we will have that a min support as per the pom. so 6 runs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057807446
##########
pom.xml:
##########
@@ -56,7 +56,7 @@ under the License.
</modules>
<properties>
- <flink.version>2.0.0</flink.version>
+ <flink.version>2.1.2</flink.version>
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>2.12.7</scala-library.version>
<jackson-bom.version>2.13.4.20221013</jackson-bom.version>
Review Comment:
Have a PR open for that https://github.com/apache/flink-connector-jdbc/pull/218, will check the ci error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5752147440
Will look into the failures locally and push the fixes. Given there may be other changes, will create a JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057863757
##########
pom.xml:
##########
@@ -56,7 +56,7 @@ under the License.
</modules>
<properties>
- <flink.version>2.0.0</flink.version>
+ <flink.version>2.1.2</flink.version>
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>2.12.7</scala-library.version>
<jackson-bom.version>2.13.4.20221013</jackson-bom.version>
Review Comment:
https://github.com/apache/flink-connector-jdbc/pull/202 this has changes for the parent as well, which is open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5763288839
Now push_pr running only with jdk 17, added latest 2.3.0 and removed 2.0.x from the matrix.
In the weekly, added 2.2.x with jdk 17 and 2.3.x with all jdk (11, 17, 21). This should cover all the scenarios exhaustively. Adding further versions don't add much benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057899711
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Will make the change.
Moving to draft, will run some more CI checks locally over all combinations once more before opening the PR. Seems like java 21 is not fully compatible with the tests right now.
To catch java21 issues I would like to keep 21 in the latest, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Refresh weekly CI's Flink/JDK matrix [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5781840496
@MartijnVisser Have rebased the PR after https://github.com/apache/flink-connector-jdbc/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057871283
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
yep, probably need to leave only one version of jdk (probably 17 for all, even default)
in case of 1.20 it should be only 8
the whole range of jdk versions will be in weekly, not in PR ci
sorry for back and forth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#issuecomment-5752102074
> please do not use AI as a co-author
Have created https://issues.apache.org/jira/browse/FLINK-40722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4058069051
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Done 1/version. Kept 21 for main, to check spanning 8 → 17 → 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Refresh weekly CI's Flink/JDK matrix [flink-connector-jdbc]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4057899711
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
Will make the change.
Moving to draft, will run some more CI checks locally over all combinations once more before opening the PR. Seems like java 21 is not fully compatible with the tests right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40723][ci] Test JDK 21 and current Flink minor lines in CI [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #228:
URL: https://github.com/apache/flink-connector-jdbc/pull/228#discussion_r4058016583
##########
.github/workflows/weekly.yml:
##########
@@ -31,21 +31,24 @@ jobs:
fail-fast: false
matrix:
flink_branches: [{
- flink: 2.2-SNAPSHOT,
- jdk: '17',
+ flink: 2.4-SNAPSHOT,
branch: main
}, {
- flink: 2.2.0,
+ flink: 2.3.0,
+ jdk: '17',
+ branch: v4.1
+ }, {
+ flink: 2.2.1,
jdk: '17',
Review Comment:
1 jdk per Flink version
we could have different jdks however then need a clarifying comment why it is like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org