You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/06/09 16:51:00 UTC
[jira] [Commented] (SOLR-13858) Clean up SolrInfoBean / SolrMetricProducer API
[ https://issues.apache.org/jira/browse/SOLR-13858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552319#comment-17552319 ]
ASF subversion and git services commented on SOLR-13858:
--------------------------------------------------------
Commit 66f5fb4c8f092974e8923ed308f20da98e6f47b0 in solr's branch refs/heads/main from Mike Drob
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=66f5fb4c8f0 ]
SOLR-13858: Remove obsolete comment (#803)
> Clean up SolrInfoBean / SolrMetricProducer API
> ----------------------------------------------
>
> Key: SOLR-13858
> URL: https://issues.apache.org/jira/browse/SOLR-13858
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 9.0
>
> Attachments: SOLR-13858.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For historical reasons both {{SolrInfoBean}} and {{SolrMetricProducer}} contain methods and constants / enums that deal with handling and reporting of metrics. In almost all cases implementations of {{SolrInfoBean}} also implement {{SolrMetricProducer}}.
> I propose to refactor this API so that {{SolrInfoBean}} simply extends {{SolrMetricProducer}}. This will reduce the API surface and eliminate multiple rote methods that subclasses must now implement.
> This is an incompatible API change so it's applicable only to version 9.0.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org