[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5513: kvm: add MV Settings for virtual GPU hardware type and memory

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5513:
URL: https://github.com/apache/cloudstack/pull/5513#discussion_r720199002



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2488,8 +2488,20 @@ protected ConsoleDef createConsoleDef() {
         return new ConsoleDef(PTY, null, null, (short)0);
     }
 
-    protected VideoDef createVideoDef() {
-        return new VideoDef(_videoHw, _videoRam);
+    protected VideoDef createVideoDef(VirtualMachineTO vmTO) {
+        Map<String, String> details = vmTO.getDetails();
+        String videoHw = _videoHw;
+        int videoRam = _videoRam;
+        if (details != null) {
+            if (details.containsKey(VideoDef.VIDEO_MODEL)) {

Review comment:
       ```suggestion
               if (details.containsKey(VmDetailConstants.VIDEO_HARDWARE)) {
   ```
   
   can use the same constants defined in VmDetailConstants.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org