You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 19:41:24 UTC
[GitHub] [airflow] kaxil opened a new pull request #12323: Fix and Unquarantine test_change_state_for_tis_without_dagrun
kaxil opened a new pull request #12323:
URL: https://github.com/apache/airflow/pull/12323
The test was simply wrong and failed since the new logic was added in
https://github.com/apache/airflow/commit/c9a97baa86762b9ba37ef71432573b7949e47e2b
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12323: Fix and Unquarantine test_change_state_for_tis_without_dagrun
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12323:
URL: https://github.com/apache/airflow/pull/12323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12323: Fix and Unquarantine test_change_state_for_tis_without_dagrun
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12323:
URL: https://github.com/apache/airflow/pull/12323#discussion_r522374938
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -852,9 +852,9 @@ def _change_state_for_tis_without_dagrun(
)
.update(ti_prop_update, synchronize_session=False)
)
- session.flush()
if tis_changed > 0:
+ session.flush()
Review comment:
Just moving the flush later in the code so that we flush it for MySQL and SQLite too
https://github.com/apache/airflow/blob/02b584a40acc29a213f471c0d85976d9e6acc6fc/airflow/jobs/scheduler_job.py#L824-L835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12323: Fix and Unquarantine test_change_state_for_tis_without_dagrun
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12323:
URL: https://github.com/apache/airflow/pull/12323#issuecomment-726311138
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org