[GitHub] [airflow] hussein-awala commented on pull request #32955: [WIP] Create a hook to manage MinIO connection

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on PR #32955:
URL: https://github.com/apache/airflow/pull/32955#issuecomment-1657231922

   @eladkal @vincbeck 
   This draft is just to discuss the idea of creating a new hook for MinIO based on S3Hook, which inherit all the methods except the test_connection (implemented in `AwsGenericHook`), because it is not possible to test it via sts, and IMO implementing a special case for MinIO in AWS hooks is not clean. And if I am not mistaken, the only way to use S3 client with MinIO is providing access and secrets keys with the endpoint url, so we can simplify the UI for MinIO connection by overriding the method  `get_connection_form_widgets`.
   
   WDYT about this and about adding it to AWS provider?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org