You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by kgiusti <gi...@git.apache.org> on 2018/09/27 19:33:32 UTC
[GitHub] qpid-dispatch pull request #385: DISPATCH-1131: add better validation of add...
GitHub user kgiusti opened a pull request:
https://github.com/apache/qpid-dispatch/pull/385
DISPATCH-1131: add better validation of address patterns and prefixes
This moves the address pattern/prefix validation to a common function
that can be share by both link routes add configured addresses.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kgiusti/dispatch DISPATCH-1131
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/385.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #385
----
commit d7b8e8a3289fd4c83dd733bfaa843956b5a38bcf
Author: Kenneth Giusti <kg...@...>
Date: 2018-09-27T17:22:51Z
DISPATCH-1131: add better validation of address patterns and prefixes
This moves the address pattern/prefix validation to a common function
that can be share by both link routes add configured addresses.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #385: DISPATCH-1131: add better validation of add...
Posted by kgiusti <gi...@git.apache.org>.
Github user kgiusti closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/385
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #385: DISPATCH-1131: add better validation of address pa...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/385
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=h1) Report
> Merging [#385](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/e3e201652ca167e9a6cd3d12ff3106165f3bb89a?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `93.1%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 84.8% 84.95% +0.14%
==========================================
Files 73 73
Lines 16448 16472 +24
==========================================
+ Hits 13949 13993 +44
+ Misses 2499 2479 -20
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/agent\_config\_link\_route.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19saW5rX3JvdXRlLmM=) | `86.95% <100%> (+7.36%)` | :arrow_up: |
| [src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==) | `96.1% <100%> (-0.14%)` | :arrow_down: |
| [src/router\_core/agent\_config\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19hZGRyZXNzLmM=) | `78.82% <91.48%> (+2.5%)` | :arrow_up: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `85.83% <0%> (-0.28%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.75% <0%> (-0.14%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.74% <0%> (+0.19%)` | :arrow_up: |
| [src/router\_core/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGVzdF9ob29rcy5j) | `88.06% <0%> (+1.7%)` | :arrow_up: |
| [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `96.42% <0%> (+1.78%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=footer). Last update [e3e2016...d7b8e8a](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #385: DISPATCH-1131: add better validation of address pa...
Posted by kgiusti <gi...@git.apache.org>.
Github user kgiusti commented on the issue:
https://github.com/apache/qpid-dispatch/pull/385
Oops left in an extraneous check..
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org