You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2023/05/18 14:14:24 UTC
[GitHub] [inlong] featzhang opened a new pull request, #8053: [INLONG-8046][Dashboard] Support batch import of sink fields
featzhang opened a new pull request, #8053:
URL: https://github.com/apache/inlong/pull/8053
- Fixes #8046
## Append field names if absent
## Overwrite field names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng merged pull request #8053: [INLONG-8046][Dashboard] Support batch import of sink fields
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng merged PR #8053:
URL: https://github.com/apache/inlong/pull/8053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang commented on a diff in pull request #8053: [INLONG-8046][Dashboard] Support batch import of sink fields
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #8053:
URL: https://github.com/apache/inlong/pull/8053#discussion_r1228021172
##########
inlong-dashboard/src/ui/components/EditableTable/index.tsx:
##########
@@ -69,6 +69,10 @@ export interface EditableTableProps
// Can add a new line? Default: true.
canAdd?: boolean;
canBatchAdd?: boolean;
Review Comment:
This is an urgent need to solve the problem of importing fields in batches online, and it will be generalized in the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #8053: [INLONG-8046][Dashboard] Support batch import of sink fields
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #8053:
URL: https://github.com/apache/inlong/pull/8053#discussion_r1198821163
##########
inlong-dashboard/src/ui/components/EditableTable/index.tsx:
##########
@@ -69,6 +69,10 @@ export interface EditableTableProps
// Can add a new line? Default: true.
canAdd?: boolean;
canBatchAdd?: boolean;
Review Comment:
A key point here is that the general abstraction of the parameters of the underlying components and the concretization of the parameters of the upper components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #8053: [INLONG-8046][Dashboard] Support batch import of sink fields
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #8053:
URL: https://github.com/apache/inlong/pull/8053#discussion_r1198817698
##########
inlong-dashboard/src/ui/components/EditableTable/index.tsx:
##########
@@ -69,6 +69,10 @@ export interface EditableTableProps
// Can add a new line? Default: true.
canAdd?: boolean;
canBatchAdd?: boolean;
Review Comment:
`EditableTable` as a base component, I don't think `upsetByFieldKey`, `fieldNameKey`, ... such parameters with obvious meanings. The parameters of `EditableTable` should be abstracted, which is the common capability of the underlying component, and the parameters added above should be implemented in the upper component.
For example, this PR adds a new capability to EditableTable, we can define it as an attribute related to append or overwrite, and the impact on fieldName and fieldKey should be implemented in the upper-level business component of Sink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org