[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #4071: Print compaction progress

["horizonzy (via GitHub)" <gi...@apache.org>]

horizonzy commented on code in PR #4071:
URL: https://github.com/apache/bookkeeper/pull/4071#discussion_r1316595538


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -591,6 +593,13 @@ void doCompactEntryLogs(double threshold, long maxTimeMillis) throws EntryLogMet
                 entryLogUsageBuckets);
 
         final int maxBucket = calculateUsageIndex(numBuckets, threshold);
+        int totalEntryLogIds = 0;
+        for (int currBucket = 0; currBucket <= maxBucket; currBucket++) {
+            totalEntryLogIds = compactableBuckets.get(currBucket).size();

Review Comment:
   `totalEntryLogIds = compactableBuckets.get(currBucket).size();` 
   ->
   `totalEntryLogIds += compactableBuckets.get(currBucket).size(); `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org