You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/05/11 05:13:06 UTC

[GitHub] [spark] itholic commented on a diff in pull request #40658: [WIP][SPARK-43024][PS] Upgrade pandas to 2.0.0

itholic commented on code in PR #40658:
URL: https://github.com/apache/spark/pull/40658#discussion_r1190642888


##########
python/pyspark/pandas/tests/test_groupby_slow.py:
##########
@@ -27,6 +27,11 @@
 
 
 class GroupBySlowTestsMixin:
+    @unittest.skipIf(
+        LooseVersion(pd.__version__) >= LooseVersion("2.0.0"),
+        "TODO(SPARK-43445): Enable GroupBySlowTests.test_split_apply_combine_on_series "
+        "for pandas 2.0.0.",
+    )

Review Comment:
   Since there are too many behavior differences to handle them within single PR, let me address the remaining tasks in multiple follow-ups. I already created multiple tickets on https://issues.apache.org/jira/browse/SPARK-42618, so I'd also hope to encourage the community members jump into remaining pandas 2.0.0 supporting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org