You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/15 10:29:37 UTC
[GitHub] [flink] kl0u opened a new pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
kl0u opened a new pull request #13649:
URL: https://github.com/apache/flink/pull/13649
## What is the purpose of the change
Currently, the `StreamGraphGenerator` is responsible for:
1. traversing the graph of `Transformations`
2. translating them to their runtime implementations
With the addition of the `TransformationTranslator` framework in [FLINK-19485](https://issues.apache.org/jira/browse/FLINK-19485), we can now pull the translation logic out of the `StreamGraphGenerator` and put it into dedicated translators, one for each type of transformation.
This PR does so for the:
* SideOutputTransformation
* PartitionTransformation
* UnionTransformation
* LegacySourceTransformation
* LegacySinkTransformation
* SourceTransformation
## Brief change log
The changes are in the `StreamGraphGenerator` and the individual `TransformationTranslator` 's.
## Verifying this change
This change is a (big) code cleanup and does not introduce any new features, so it is expected to be covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b24089c70ecc6105655f311985270562a120e272 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678)
* 75c459b97b01bf7a67f95b67e7d611e4d19d4c88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c459b97b01bf7a67f95b67e7d611e4d19d4c88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #13649:
URL: https://github.com/apache/flink/pull/13649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b24089c70ecc6105655f311985270562a120e272 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7871",
"triggerID" : "712242925",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75c459b97b01bf7a67f95b67e7d611e4d19d4c88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b24089c70ecc6105655f311985270562a120e272 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678)
* 75c459b97b01bf7a67f95b67e7d611e4d19d4c88 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7871",
"triggerID" : "712242925",
"triggerType" : "MANUAL"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "712242925",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75c459b97b01bf7a67f95b67e7d611e4d19d4c88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7871) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709271794
@aljoscha yes, I agree. I left it just to make sure that I do not break anything but I am planning to do a "clean-up" also as a follow-up when all transformations (including iterations) are ported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709122380
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b24089c70ecc6105655f311985270562a120e272 (Thu Oct 15 10:31:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"triggerType" : "PUSH"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7871",
"triggerID" : "712242925",
"triggerType" : "MANUAL"
}, {
"hash" : "75c459b97b01bf7a67f95b67e7d611e4d19d4c88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839",
"triggerID" : "712242925",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75c459b97b01bf7a67f95b67e7d611e4d19d4c88 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7871) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-712242925
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b24089c70ecc6105655f311985270562a120e272 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-712102817
Thanks for the review @aljoscha , I rebased and I will merge soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13649: [FLINK-19571] Port existing Transformations to the new TransformationTranslator framework
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13649:
URL: https://github.com/apache/flink/pull/13649#issuecomment-709157195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b24089c70ecc6105655f311985270562a120e272",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678",
"triggerID" : "b24089c70ecc6105655f311985270562a120e272",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b24089c70ecc6105655f311985270562a120e272 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org