[GitHub] [flink] zoltar9264 commented on a change in pull request #17496: [FLINK-24562][yarn] YarnResourceManagerDriverTest should not use ContainerStatusPBImpl.newInstance

[GitBox <gi...@apache.org>]

zoltar9264 commented on a change in pull request #17496:
URL: https://github.com/apache/flink/pull/17496#discussion_r732103414



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/TestingContainerStatus.java
##########
@@ -21,16 +21,23 @@
 import org.apache.hadoop.yarn.api.records.ContainerId;
 import org.apache.hadoop.yarn.api.records.ContainerState;
 import org.apache.hadoop.yarn.api.records.ContainerStatus;
-import org.apache.hadoop.yarn.api.records.impl.pb.ContainerStatusPBImpl;
 
 /** A {@link ContainerStatus} implementation for testing. */
-class TestingContainerStatus extends ContainerStatusPBImpl {
+class TestingContainerStatus extends ContainerStatus {

Review comment:
       Thanks for reply. I change this base on ContainerStatusPBImpl is marked 'Private' without considering what you said. After understand these, I think extends ContainerStatusPBImpl is better. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org