You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2026/06/10 15:34:52 UTC
[PR] [MINOR][SQL] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf [spark]
stevomitric opened a new pull request, #56431:
URL: https://github.com/apache/spark/pull/56431
### What changes were proposed in this pull request?
This PR deletes that validator and moves the requirement into the getter: `SQLConf.timestampNanosTypesEnabled` now returns true only when `spark.sql.types.framework.enabled` is also true.
### Why are the changes needed?
Enabling the flag the normal way crashes Spark:
```scala
val spark = SparkSession.builder()
.master("local[1]")
.config("spark.sql.timestampNanosTypes.enabled", "true")
.getOrCreate() // fine — options are applied lazily
spark.sql("SELECT 1") // java.lang.StackOverflowError
```
The validator runs while the session conf is being built (during `mergeSparkConf`), and `SQLConf.get` asks for that same conf which starts building it again, forever.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Tests in this PR.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Fable 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57207][SQL][FOLLOWUP] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #56431: [SPARK-57207][SQL][FOLLOWUP] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf
URL: https://github.com/apache/spark/pull/56431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf [spark]
Posted by "stevomitric (via GitHub)" <gi...@apache.org>.
stevomitric commented on PR #56431:
URL: https://github.com/apache/spark/pull/56431#issuecomment-4671849370
cc @MaxGekk PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57207][SQL][FOLLOWUP] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf [spark]
Posted by "stevomitric (via GitHub)" <gi...@apache.org>.
stevomitric commented on PR #56431:
URL: https://github.com/apache/spark/pull/56431#issuecomment-4672678967
> @stevomitric Could you replace [MINOR] by the JIRA ticket which introduced the issue and add the tag [FOLLOWUP].
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #56431:
URL: https://github.com/apache/spark/pull/56431#issuecomment-4672304682
@stevomitric Could you replace `[MINOR]` by the JIRA ticket which introduced the issue and add the tag `[FOLLOWUP]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57207][SQL][FOLLOWUP] Fix StackOverflowError when setting timestampNanosTypes.enabled via SparkConf [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #56431:
URL: https://github.com/apache/spark/pull/56431#issuecomment-4673508512
+1, LGTM. Merging to master/4.x.
Thank you, @stevomitric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org