[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054795#comment-13054795 ] 

jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

There is no test case for testing coprocesors class loading from hdfs or local file system. 

Add test cases for cp class loading. 

It does:
- compile a cp implementation on the fly by Java compiler api
- build a jar file from the compiled classes
- copy the jar to local file system or hdfs so it can be loaded for a region 


This addresses bug HBase-3516.
    https://issues.apache.org/jira/browse/HBase-3516


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION 

Diff: https://reviews.apache.org/r/963/diff


Testing
-------


Thanks,

Mingjie



> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs. 
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-3516
>                 URL: https://issues.apache.org/jira/browse/HBASE-3516
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.90.0
>            Reporter: Mingjie Lai
>            Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually. 
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira