答复: Subversion 2.0

["钱海远 (Nathan)" <qi...@hikvision.com>]

Dear Develop Team,

We have created a system for pre-commit review in  our company (Force Review, or pre-commit hooks will reject commit), as shown below.

But SVN does not support staging code area. Can it be developed in 2.0?

If we can have a staging area, we can build pre-commit action simple , such as pre-commit builds, check the quality of the code before it is committed. Now we are also implementing it in a similar way like FR , code consistency is difficult to judge, and user’s operation are complex.


[cid:image001.png@01D54632.FAD83480]

________________________________
Best Regards!
Haiyuan Qian
R & D Management Group
Hangzhou Hikvision Digital Technology Co.,Ltd
No.555 Qianmo Road, Binjiang District, Hangzhou 310052, China
M (86)18969199712

本邮件及其附件含有海康威视公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！
This e-mail and its attachments contain confidential information from HIKVISION, which is intended only for  the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other  than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

发件人: Nathan Hartman <ha...@gmail.com>
发送时间: 2019年7月3日 0:41
收件人: Markus Schaber <m....@codesys.com>
抄送: Thomas Singer <th...@syntevo.com>; Subversion Developers <de...@subversion.apache.org>
主题: Re: Subversion 2.0

On Fri, Jun 28, 2019 at 12:51 PM Markus Schaber <m....@codesys.com>> wrote:
It's a very powerful feature, on par or even superior to other (D)VCSes - as long as we manage to keep the interface clear enough that users can handle everything.

I'm always astonished how complicated GIT can be for seemingly "simple" tasks, and even the available GUIs are not always helpful. HG is doing a much better job here, as far as I can see...

It stand and falls with the user interface.

And we should take it seriously from the beginning. When the new features are implemented with unusable/complex UI first, users will want to try it, fail, and turn away. We won't be able to catch them later when the UI is better...

I agree. A bad user interface will result in complaints that repeat
around the Internet in perpetuity, even after the problems are fixed.
I think we know this from experience! Also, once the interface gets
"grandfathered in," it can't / won't change because of compatibility.

I'm studying this issue and I'll be back with some concrete
suggestions; in the meantime I'd love to hear your thoughts as well!
Especially use cases. :-)


________________________________
CONFIDENTIALITY NOTICE:

This electronic message is intended to be viewed only by the individual or entity to whom it is addressed. It may contain information that is privileged, confidential and exempt from disclosure under applicable law. Any dissemination, distribution or copying of this communication is strictly prohibited without our prior permission. If the reader of this message is not the intended recipient, or the employee or agent responsible for delivering the message to the intended recipient, or if you have received this communication in error, please notify us immediately by return e-mail and delete the original message and any copies of it from your computer system. For further information about Hikvision company. please see our website at www.hikvision.com<http://www.hikvision.com>

Re: Subversion 2.0

[Branko Čibej <br...@apache.org>]

On 29.07.2019 11:36, 钱海远(Nathan) wrote:
>
> Dear Develop Team,
>
>  
>
> We have created a system for pre-commit review in  our company (Force
> Review, or pre-commit hooks will reject commit), as shown below.
>
>  
>
> But SVN does not support staging code area.
>

There's nothing wrong with using the uncommitted transaction as the
"staging code area," although the command-line client will probably try
to remove it after it times out, so you'd have to integrate the code
review logic with the client somehow.

Or you could use temporary branches: the code review logic could create
a commit on a temporary branch from the commit transaction, then reject
the commit. Once approved, the temporary branch would be merged back to
the original commit target. Or you could save the transaction itself and
then replay it locally.

In any case I doubt that you really need support from core Subversion
for this. If you can implement master/master replication, surely you can
also implement some kind of "pre" commit review workflow. You don't need
Subversion 2.0 for that.

-- Brane

Re: Subversion 2.0

[Paul Hammant <pa...@hammant.org>]

The "shelve" functionality in Subversion may be grown into a "continuous
review" system in the future. If you can't wait that long Rhodecode and
Assembla both give Subversion a code review capability today and would be
able to migrate your existing repo to their tech/service. Various CollabNet
products may do so too.

- Paul