You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2015/12/02 06:15:15 UTC
ant git commit: Prevent string concatenations as argument to
"StringBuffer.append()"
Repository: ant
Updated Branches:
refs/heads/master 9b210733d -> f15c3de41
Prevent string concatenations as argument to "StringBuffer.append()"
Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/f15c3de4
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/f15c3de4
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/f15c3de4
Branch: refs/heads/master
Commit: f15c3de41b09131e1a7967911c8f1088700b6578
Parents: 9b21073
Author: Vladislav Bauer <ba...@gmail.com>
Authored: Mon Nov 30 03:06:21 2015 +0600
Committer: Stefan Bodewig <bo...@apache.org>
Committed: Wed Dec 2 06:14:51 2015 +0100
----------------------------------------------------------------------
src/main/org/apache/tools/ant/Main.java | 2 +-
src/main/org/apache/tools/ant/Project.java | 2 +-
.../ant/taskdefs/optional/depend/constantpool/ConstantPool.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ant/blob/f15c3de4/src/main/org/apache/tools/ant/Main.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/Main.java b/src/main/org/apache/tools/ant/Main.java
index a9c23a5..85aaa28 100644
--- a/src/main/org/apache/tools/ant/Main.java
+++ b/src/main/org/apache/tools/ant/Main.java
@@ -1287,7 +1287,7 @@ public class Main implements AntMain {
spaces += spaces;
}
final StringBuilder msg = new StringBuilder();
- msg.append(heading + lSep + lSep);
+ msg.append(heading).append(lSep).append(lSep);
final int size = names.size();
for (int i = 0; i < size; i++) {
msg.append(" ");
http://git-wip-us.apache.org/repos/asf/ant/blob/f15c3de4/src/main/org/apache/tools/ant/Project.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java
index 3a0c4b8..e916002 100644
--- a/src/main/org/apache/tools/ant/Project.java
+++ b/src/main/org/apache/tools/ant/Project.java
@@ -1845,7 +1845,7 @@ public class Project implements ResourceFactory {
for (int j = 0; j < root.length; j++) {
buf.append((j == 0) ? " `" : ", `").append(root[j]).append('\'');
}
- buf.append(" is " + ret);
+ buf.append(" is ").append(ret);
log(buf.toString(), MSG_VERBOSE);
final Vector<Target> complete = (returnAll) ? ret : new Vector<Target>(ret);
http://git-wip-us.apache.org/repos/asf/ant/blob/f15c3de4/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java b/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java
index 67d366b..9bec0ed 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java
@@ -348,7 +348,7 @@ public class ConstantPool {
final int size = entries.size();
for (int i = 0; i < size; ++i) {
- sb.append("[" + i + "] = " + getEntry(i) + "\n");
+ sb.append('[').append(i).append("] = ").append(getEntry(i)).append('\n');
}
return sb.toString();