You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by jc...@apache.org on 2018/05/14 21:54:03 UTC
calcite git commit: [CALCITE-2309] Dialects: Hive dialect does not
support charsets in constants
Repository: calcite
Updated Branches:
refs/heads/master 4433b102b -> 36b1d5c34
[CALCITE-2309] Dialects: Hive dialect does not support charsets in constants
Project: http://git-wip-us.apache.org/repos/asf/calcite/repo
Commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/36b1d5c3
Tree: http://git-wip-us.apache.org/repos/asf/calcite/tree/36b1d5c3
Diff: http://git-wip-us.apache.org/repos/asf/calcite/diff/36b1d5c3
Branch: refs/heads/master
Commit: 36b1d5c34f0f94cd95f832a0d9aa2e9f89210e1d
Parents: 4433b10
Author: Jesus Camacho Rodriguez <jc...@apache.org>
Authored: Mon May 14 14:53:57 2018 -0700
Committer: Jesus Camacho Rodriguez <jc...@apache.org>
Committed: Mon May 14 14:53:57 2018 -0700
----------------------------------------------------------------------
.../java/org/apache/calcite/sql/dialect/HiveSqlDialect.java | 4 ++++
.../apache/calcite/rel/rel2sql/RelToSqlConverterTest.java | 8 ++++++++
2 files changed, 12 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/calcite/blob/36b1d5c3/core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java b/core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java
index d611962..6896614 100644
--- a/core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java
+++ b/core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java
@@ -59,6 +59,10 @@ public class HiveSqlDialect extends SqlDialect {
return null;
}
+
+ @Override public boolean supportsCharSet() {
+ return false;
+ }
}
// End HiveSqlDialect.java
http://git-wip-us.apache.org/repos/asf/calcite/blob/36b1d5c3/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java b/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
index 8ddaaa7..6673fac 100644
--- a/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
+++ b/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
@@ -357,6 +357,14 @@ public class RelToSqlConverterTest {
sql(query).ok(expected);
}
+ @Test public void testHiveSelectCharset() {
+ String query = "select \"hire_date\", cast(\"hire_date\" as varchar(10)) "
+ + "from \"foodmart\".\"reserve_employee\"";
+ final String expected = "SELECT hire_date, CAST(hire_date AS VARCHAR(10))\n"
+ + "FROM foodmart.reserve_employee";
+ sql(query).withHive().ok(expected);
+ }
+
@Test public void testSelectQueryWithLimitClause() {
String query = "select \"product_id\" from \"product\" limit 100 offset 10";
final String expected = "SELECT product_id\n"