You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-eshu (GitHub)" <gi...@apache.org> on 2019/01/09 01:16:19 UTC
[GitHub] [geode] pivotal-eshu opened pull request #3060: GEODE-6260:
Do not cleanup non-dirty entries in transactional set operation
[ Full content available at: https://github.com/apache/geode/pull/3060 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu closed pull request #3060: GEODE-6260:
Do not cleanup non-dirty entries in transactional set operation
Posted by "pivotal-eshu (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-eshu ]
[ Full content available at: https://github.com/apache/geode/pull/3060 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu commented on pull request #3060:
GEODE-6260: Do not cleanup non-dirty entries in transactional set operation
Posted by "pivotal-eshu (GitHub)" <gi...@apache.org>.
Will make the changes by using the more descriptive comments.
[ Full content available at: https://github.com/apache/geode/pull/3060 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #3060:
GEODE-6260: Do not cleanup non-dirty entries in transactional set operation
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
Does "!createIfAbsent" indicate that this is a set operation? If so I think you should add a comment here.
Something like "createReadEntry will only returns null if createIfAbsent is false. CreateIfAbsent will only be false when this method is called by set operations. In that case we do not want the TXState to have a TXEntryState."
[ Full content available at: https://github.com/apache/geode/pull/3060 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org