You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/08 01:44:07 UTC

Review Request 37241: Renamed master's "/call" endpoint to "/api/v1/scheduler".

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.


Bugs: MESOS-2860
    https://issues.apache.org/jira/browse/MESOS-2860


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 
  src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e 
  src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 
  src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 

Diff: https://reviews.apache.org/r/37241/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 37241: Renamed master's "/call" endpoint to "/api/v1/scheduler".

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/#review94605
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37240, 37241]

All tests passed.

- Mesos ReviewBot


On Aug. 7, 2015, 11:44 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37241/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-2860
>     https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 
>   src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e 
>   src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37241/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 37241: Renamed master's "/call" endpoint to "/api/v1/scheduler".

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/#review94595
-----------------------------------------------------------

Ship it!


Ship It!

- Isabel Jimenez


On Aug. 7, 2015, 11:44 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37241/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-2860
>     https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 
>   src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e 
>   src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37241/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>