You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/16 19:15:47 UTC

[GitHub] [samza] mynameborat commented on a change in pull request #1305: SAMZA-2479: Add configurable default for min compaction lag ms

mynameborat commented on a change in pull request #1305: SAMZA-2479: Add configurable default for min compaction lag ms
URL: https://github.com/apache/samza/pull/1305#discussion_r393256390
 
 

 ##########
 File path: docs/learn/documentation/versioned/jobs/configuration-table.html
 ##########
 @@ -1585,6 +1585,22 @@ <h1>Samza Configuration Reference</h1>
                     </td>
                 </tr>
 
+                <tr>
+                    <td class="property" id="store-default-changelog-min-compaction-lag-ms">stores.default.changelog.min.compaction.lag.ms</td>
+                    <td class="default">14400000</td>
+                    <td class="description">
+                        This property defines the default minimum period that must pass before a changelog message can be compacted.
+                    </td>
+                </tr>
+
+                <tr>
+                    <td class="property" id="store-changelog-min-compaction-lag-ms">stores.<span class="store">store-name</span>.changelog.min.compaction.lag.ms</td>
+                    <td class="default">stores.default.changelog.min.compaction.lag.ms</td>
+                    <td class="description">
+                        This property defines the minimum period that must pass before a message in the store's changelog can be compacted.
 
 Review comment:
   Can you shed some light on how this configuration impacts application (if any), on Kafka?
   Are there any gotchas around how to configure this if you have TTL'd enabled on a log compacted store? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services