You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "m-kuhn (via GitHub)" <gi...@apache.org> on 2025/03/04 09:04:45 UTC
[PR] Fix install dirs [arrow-nanoarrow]
m-kuhn opened a new pull request, #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715
Ensures the proper target directories also on windows (`dll`s to `bin`, `lib`s to `lib`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install dirs [arrow-nanoarrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715#issuecomment-2708396156
Sorry I reviewed, lgtm. My review didn't go through for some reason :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install dirs [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715#issuecomment-2708387270
Merging for now, but I'm happy to follow-up with any edits!
@m-kuhn Do you need a release to finish the vcpkg port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install dirs [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715#issuecomment-2708650941
No worries! I just felt bad pinging you twice 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install dirs [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install dirs [arrow-nanoarrow]
Posted by "m-kuhn (via GitHub)" <gi...@apache.org>.
m-kuhn commented on PR #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715#issuecomment-2708678421
No release needed, we can keep a patch in vcpkg and drop it on next update
Thanks for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install dirs [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #715:
URL: https://github.com/apache/arrow-nanoarrow/pull/715#issuecomment-2697975574
Thank you!
This is all good from my end, but @assignUser if you have the bandwidth, could you take a look as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org