You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Julien NICOLAS <ju...@nomaka.fr> on 2015/11/01 22:41:14 UTC

Widget-Style

Hi,

I was thinking that I found a bug but the source code seems to explain 
me that it is a feature...

In menu xml file, I can define widget-style for an item. But when this 
item is selected, the widget-style is push to the link style of the item.

For me it's strange... I start to solve this problem but the source code 
get the widget-style of the item if this one is in selected status.

Is anybody have more information to help me to understand the reason or 
can I consider this as a bug ?

Thanks,

Julien.

Re: Widget-Style

Posted by Julien NICOLAS <ju...@nomaka.fr>.
It's on the 13.07 release, I'll check for the 14 and the trunk

Le 01/11/2015 22:41, Julien NICOLAS a écrit :
> Hi,
>
> I was thinking that I found a bug but the source code seems to explain 
> me that it is a feature...
>
> In menu xml file, I can define widget-style for an item. But when this 
> item is selected, the widget-style is push to the link style of the item.
>
> For me it's strange... I start to solve this problem but the source 
> code get the widget-style of the item if this one is in selected status.
>
> Is anybody have more information to help me to understand the reason 
> or can I consider this as a bug ?
>
> Thanks,
>
> Julien.
>

Re: Widget-Style

Posted by Julien NICOLAS <ju...@nomaka.fr>.
Hi Adrian,

Thank you for your very good explanation, I'll correct it asap.

Regards,

Julien.

Le 02/11/2015 01:21, Adrian Crum a écrit :
> Most likely you have found a bug in a transition phase from the old 
> method of styling to the new method of styling.
>
> In the "old days" screen widgets had styles assigned at a very 
> granular level. Around 2007 or so, that was changed so only a widget's 
> container (an HTML <div> for example) was styled, and the elements it 
> contained were styled with descendent CSS selectors (CSS inheritance).
>
> You can see that concept at work here:
>
> https://cwiki.apache.org/confluence/display/OFBADMIN/HTML+and+CSS+Best+Practices 
>
>
> "...styles should be applied to containers, and the container's style 
> should style all of the elements it contains."
>
> and here:
>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles 
>
>
> Don't assume the widget code is correct. It may be in need of an update.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 11/1/2015 1:41 PM, Julien NICOLAS wrote:
>> Hi,
>>
>> I was thinking that I found a bug but the source code seems to explain
>> me that it is a feature...
>>
>> In menu xml file, I can define widget-style for an item. But when this
>> item is selected, the widget-style is push to the link style of the 
>> item.
>>
>> For me it's strange... I start to solve this problem but the source code
>> get the widget-style of the item if this one is in selected status.
>>
>> Is anybody have more information to help me to understand the reason or
>> can I consider this as a bug ?
>>
>> Thanks,
>>
>> Julien.
>>

Re: Widget-Style

Posted by Adrian Crum <ad...@sandglass-software.com>.
Most likely you have found a bug in a transition phase from the old 
method of styling to the new method of styling.

In the "old days" screen widgets had styles assigned at a very granular 
level. Around 2007 or so, that was changed so only a widget's container 
(an HTML <div> for example) was styled, and the elements it contained 
were styled with descendent CSS selectors (CSS inheritance).

You can see that concept at work here:

https://cwiki.apache.org/confluence/display/OFBADMIN/HTML+and+CSS+Best+Practices

"...styles should be applied to containers, and the container's style 
should style all of the elements it contains."

and here:

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles

Don't assume the widget code is correct. It may be in need of an update.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 11/1/2015 1:41 PM, Julien NICOLAS wrote:
> Hi,
>
> I was thinking that I found a bug but the source code seems to explain
> me that it is a feature...
>
> In menu xml file, I can define widget-style for an item. But when this
> item is selected, the widget-style is push to the link style of the item.
>
> For me it's strange... I start to solve this problem but the source code
> get the widget-style of the item if this one is in selected status.
>
> Is anybody have more information to help me to understand the reason or
> can I consider this as a bug ?
>
> Thanks,
>
> Julien.
>