You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/30 03:01:18 UTC
Review Request 13049: Added /health endpoints to the Master and Slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13049/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-585
https://issues.apache.org/jira/browse/MESOS-585
Repository: mesos-git
Description
-------
See MESOS-585. An explicit /health endpoint is useful as existing users tend to use /stats.json or /vars for health checking.
Diffs
-----
src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
src/slave/http.cpp b7d1582969e836eb040dd98e28a05b2f6044c8d3
src/slave/slave.hpp 5a0fdd92529e85fbea2a3591b2c731182b736404
src/slave/slave.cpp 54eaf8f5db47ff481b0590d214746cec63581680
Diff: https://reviews.apache.org/r/13049/diff/
Testing
-------
make check and curl
Thanks,
Ben Mahler
Re: Review Request 13049: Added /health endpoints to the Master and Slave.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13049/#review24259
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 30, 2013, 6:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13049/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-585
> https://issues.apache.org/jira/browse/MESOS-585
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-585. An explicit /health endpoint is useful as existing users tend to use /stats.json or /vars for health checking.
>
>
> Diffs
> -----
>
> src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
> src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
> src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
> src/slave/http.cpp b7d1582969e836eb040dd98e28a05b2f6044c8d3
> src/slave/slave.hpp 5a0fdd92529e85fbea2a3591b2c731182b736404
> src/slave/slave.cpp 54eaf8f5db47ff481b0590d214746cec63581680
>
> Diff: https://reviews.apache.org/r/13049/diff/
>
>
> Testing
> -------
>
> make check and curl
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13049: Added /health endpoints to the Master and Slave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13049/
-----------------------------------------------------------
(Updated July 30, 2013, 6:26 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Added help pages for the /health endpoints. Will be adding help pages for the other master / slave endpoints as well! (In a separate review).
Bugs: MESOS-585
https://issues.apache.org/jira/browse/MESOS-585
Repository: mesos-git
Description
-------
See MESOS-585. An explicit /health endpoint is useful as existing users tend to use /stats.json or /vars for health checking.
Diffs (updated)
-----
src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
src/slave/http.cpp b7d1582969e836eb040dd98e28a05b2f6044c8d3
src/slave/slave.hpp 5a0fdd92529e85fbea2a3591b2c731182b736404
src/slave/slave.cpp 54eaf8f5db47ff481b0590d214746cec63581680
Diff: https://reviews.apache.org/r/13049/diff/
Testing
-------
make check and curl
Thanks,
Ben Mahler
Re: Review Request 13049: Added /health endpoints to the Master and Slave.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13049/#review24199
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/13049/#comment48039>
Can you add the help while you are at it?
src/slave/slave.cpp
<https://reviews.apache.org/r/13049/#comment48040>
ditto
- Vinod Kone
On July 30, 2013, 1:01 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13049/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 1:01 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-585
> https://issues.apache.org/jira/browse/MESOS-585
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-585. An explicit /health endpoint is useful as existing users tend to use /stats.json or /vars for health checking.
>
>
> Diffs
> -----
>
> src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
> src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
> src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
> src/slave/http.cpp b7d1582969e836eb040dd98e28a05b2f6044c8d3
> src/slave/slave.hpp 5a0fdd92529e85fbea2a3591b2c731182b736404
> src/slave/slave.cpp 54eaf8f5db47ff481b0590d214746cec63581680
>
> Diff: https://reviews.apache.org/r/13049/diff/
>
>
> Testing
> -------
>
> make check and curl
>
>
> Thanks,
>
> Ben Mahler
>
>