You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/07/15 19:34:29 UTC

Review Request 23492: Added metrics for port mapping network isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23492/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/slave/containerizer/isolators/network/port_mapping.hpp 51d3ed5 
  src/slave/containerizer/isolators/network/port_mapping.cpp dad1360 

Diff: https://reviews.apache.org/r/23492/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 23492: Added metrics for port mapping network isolator.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23492/#review47787
-----------------------------------------------------------

Ship it!



src/slave/containerizer/isolators/network/port_mapping.hpp
<https://reviews.apache.org/r/23492/#comment83985>

    s/*_not_exist/*_do_not_exist/


- Vinod Kone


On July 15, 2014, 5:34 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23492/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 5:34 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 51d3ed5 
>   src/slave/containerizer/isolators/network/port_mapping.cpp dad1360 
> 
> Diff: https://reviews.apache.org/r/23492/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>