[jira] [Commented] (STORM-375) Smarter downloading of assignments by supervisors and workers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177855#comment-14177855 ] 

ASF GitHub Bot commented on STORM-375:
--------------------------------------

Github user xiaokang commented on a diff in the pull request:

    https://github.com/apache/storm/pull/167#discussion_r19126987
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -340,6 +354,7 @@
           (.put local-state
                 LS-LOCAL-ASSIGNMENTS
                 new-assignment)
    +      (swap! (:assignment-versions supervisor) versions)
    --- End diff --
    
    It maybe that "rest!" should be used instead of "swap!". We tested this PR in one cluster and found that :assignment-versions atom is always empty.


> Smarter downloading of assignments by supervisors and workers
> -------------------------------------------------------------
>
>                 Key: STORM-375
>                 URL: https://issues.apache.org/jira/browse/STORM-375
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>             Fix For: 0.9.3
>
>
> Periodically the supervisors and workers each download their assignments from zookeeper, and the traffic begins to saturate the network and hammer zookeeper as we scale. Having these daemons only grab the assignments when the zookeeper path's version number changes reduces this traffic considerably, along with STORM-376.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)