You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/14 05:16:54 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #43: !str Eagerly fails flow if the future is already failed.
He-Pin opened a new pull request, #43:
URL: https://github.com/apache/incubator-pekko/pull/43
If the future is already failed, it will fail the flow even if there is no downstream demands now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed pull request #43: !str Eagerly fails flow if the future is already failed.
Posted by GitBox <gi...@apache.org>.
He-Pin closed pull request #43: !str Eagerly fails flow if the future is already failed.
URL: https://github.com/apache/incubator-pekko/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #43: !str Eagerly fails flow if the future is already failed.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #43:
URL: https://github.com/apache/incubator-pekko/pull/43#discussion_r1021098482
##########
akka-stream-tests/src/test/scala/akka/stream/scaladsl/FlowFromFutureSpec.scala:
##########
@@ -33,6 +34,13 @@ class FlowFromFutureSpec extends StreamSpec {
c.expectSubscriptionAndError(ex)
}
+ "fails flow from already failed Future even no demands" in {
+ val ex = new RuntimeException("test") with NoStackTrace
+ val sub = Source.fromFuture(Future.failed[Int](ex))
+ .runWith(TestSink.probe)
+ sub.expectSubscriptionAndError(ex)
Review Comment:
a new test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #43: !str Eagerly fails flow if the future is already failed.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on PR #43:
URL: https://github.com/apache/incubator-pekko/pull/43#issuecomment-1316216975
oops, will close:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org