You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/09 07:43:48 UTC
[GitHub] [flink] zentol opened a new pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
zentol opened a new pull request #18676:
URL: https://github.com/apache/flink/pull/18676
The flink-table-planner currently creates 2 artifacts. 1 jar containing the planner and various dependencies for the cases where the planner is used directly, and another jar that additionally bundles scala for cases where the loader is used.
The latter artifact is purely an intermediate build artifact, and as such we usually wouldn't want to publish it. This is particularly important because this jar doesn't have a correct NOTICE, and having different NOTICE files for different artifacts is surprisingly tricky.
We should just rework this into a separate module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802611037
##########
File path: flink-table/README.md
##########
@@ -65,7 +66,8 @@ If you want to use Table API & SQL, check out the [documentation](https://nightl
### Notes
-No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
+No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
Review comment:
Gotcha, opened an issue here to track it https://issues.apache.org/jira/browse/FLINK-26054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
}, {
"hash" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997",
"triggerID" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51f70c89ee9e6ab9964793a032653fc027e498d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
}, {
"hash" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad0e032399b3b422d20e018161c0030ca84d08e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977)
* 51f70c89ee9e6ab9964793a032653fc027e498d0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802495493
##########
File path: flink-table/flink-table-planner-loader-helper/pom.xml
##########
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table</artifactId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-table-planner-loader-helper</artifactId>
Review comment:
sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802592252
##########
File path: flink-table/README.md
##########
@@ -65,7 +66,8 @@ If you want to use Table API & SQL, check out the [documentation](https://nightl
### Notes
-No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
+No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
Review comment:
Is it possible to do so but allowing flink-table-planner for testing purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
}, {
"hash" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997",
"triggerID" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"triggerType" : "PUSH"
}, {
"hash" : "f76952a792331a65c0152be8bced92e9dbd45659",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31091",
"triggerID" : "f76952a792331a65c0152be8bced92e9dbd45659",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f76952a792331a65c0152be8bced92e9dbd45659 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad0e032399b3b422d20e018161c0030ca84d08e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802502438
##########
File path: flink-table/README.md
##########
@@ -65,7 +66,8 @@ If you want to use Table API & SQL, check out the [documentation](https://nightl
### Notes
-No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
+No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
Review comment:
@slinkydeveloper Have you considered enforcing this via the enforcer plugin, similarly to what we do for [flink-rpc-akka](https://github.com/apache/flink/blob/master/pom.xml#L1730)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802469048
##########
File path: flink-table/flink-table-planner-loader-helper/pom.xml
##########
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table</artifactId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-table-planner-loader-helper</artifactId>
Review comment:
Perhaps name it loader bundle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad0e032399b3b422d20e018161c0030ca84d08e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442771
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dad0e032399b3b422d20e018161c0030ca84d08e (Wed Feb 09 07:48:34 UTC 2022)
**Warnings:**
* **4 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
}, {
"hash" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997",
"triggerID" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"triggerType" : "PUSH"
}, {
"hash" : "f76952a792331a65c0152be8bced92e9dbd45659",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31091",
"triggerID" : "f76952a792331a65c0152be8bced92e9dbd45659",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51f70c89ee9e6ab9964793a032653fc027e498d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997)
* f76952a792331a65c0152be8bced92e9dbd45659 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802608726
##########
File path: flink-table/README.md
##########
@@ -65,7 +66,8 @@ If you want to use Table API & SQL, check out the [documentation](https://nightl
### Notes
-No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
+No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
Review comment:
Yes, like this:
```
<execution>
<id>forbid-direct-table-planner-dependencies</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<bannedDependencies>
<excludes>
<exclude>org.apache.flink:flink-table-planner</exclude>
</excludes>
<includes>
<include>org.apache.flink:flink-table-planner:*:test</include>
</includes>
<message>
Direct dependencies on flink-table-planner are not allowed.
</message>
</bannedDependencies>
</rules>
</configuration>
</execution>
```
You'd have to replicate this for runtime, planner-loader, planner-loader-bundle, and then work your way through various exceptions and disable the execution in the respective module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
}, {
"hash" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997",
"triggerID" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad0e032399b3b422d20e018161c0030ca84d08e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977)
* 51f70c89ee9e6ab9964793a032653fc027e498d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
}, {
"hash" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997",
"triggerID" : "51f70c89ee9e6ab9964793a032653fc027e498d0",
"triggerType" : "PUSH"
}, {
"hash" : "f76952a792331a65c0152be8bced92e9dbd45659",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f76952a792331a65c0152be8bced92e9dbd45659",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51f70c89ee9e6ab9964793a032653fc027e498d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30997)
* f76952a792331a65c0152be8bced92e9dbd45659 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #18676:
URL: https://github.com/apache/flink/pull/18676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18676:
URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977",
"triggerID" : "dad0e032399b3b422d20e018161c0030ca84d08e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad0e032399b3b422d20e018161c0030ca84d08e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30977)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18676:
URL: https://github.com/apache/flink/pull/18676#discussion_r802513010
##########
File path: flink-table/README.md
##########
@@ -65,7 +66,8 @@ If you want to use Table API & SQL, check out the [documentation](https://nightl
### Notes
-No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
+No module except `flink-table-planner` should depend on `flink-table-runtime` in production classpath,
Review comment:
I didn't knew about that, but yep it probably makes sense to do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org