You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/23 22:03:00 UTC
[jira] [Commented] (AIRFLOW-4396) Add a link to Elasticsearch
frontend for logs if available
[ https://issues.apache.org/jira/browse/AIRFLOW-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824571#comment-16824571 ]
ASF GitHub Bot commented on AIRFLOW-4396:
-----------------------------------------
kunalyogenshah commented on pull request #5164: [AIRFLOW-4396] Provide a link to external Elasticsearch logs in UI.
URL: https://github.com/apache/airflow/pull/5164
### Jira
- [ ] My PR addresses the following:
- https://issues.apache.org/jira/browse/AIRFLOW-4396
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR adds a new button to the Airflow UI next to "View log" ("View log in ES"). It provides an external URL for visualizing the log, and renders the latest try for the Task, DAG and execution being looked up. This button is controlled by a new `elasticsearch_frontend` conf param, which provides the template URL for viewing the corresponding log. Screenshot below :
Documentation update is pending code review. Will update documentation after.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Unit tested the UI and checked the console for errors in the JS. Button doesn't show up if the param is not defined.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add a link to Elasticsearch frontend for logs if available
> ----------------------------------------------------------
>
> Key: AIRFLOW-4396
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4396
> Project: Apache Airflow
> Issue Type: Improvement
> Components: webserver
> Reporter: Kunal Shah
> Assignee: Kunal Shah
> Priority: Minor
>
> If elasticsearch backend is being used for logs collection, then there may exist a frontend to redirect for the client to view their logs. In those cases, we can provide a link to the external UI which may allow visualizing the logs in a more queryable fashion.
> The idea is to add a new conf param for elasticsearch for a template URL to the frontend, which can formatted with the elasticsearch log ID template.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)