You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/06/13 02:48:41 UTC
[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
waitinfuture opened a new pull request, #1580:
URL: https://github.com/apache/incubator-celeborn/pull/1580
…eful is disabled
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Worker should report WorkerLost instead of WorkerUnavailable in it's shutdown hook if graceful shutdown is disabled.
### Why are the changes needed?
To avoid unnecessary commit file requests from lifecycle manager since it's not graceful shutdown.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1580:
URL: https://github.com/apache/incubator-celeborn/pull/1580#issuecomment-1588437601
cc @RexXiong @AngersZhuuuu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
URL: https://github.com/apache/incubator-celeborn/pull/1580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1580:
URL: https://github.com/apache/incubator-celeborn/pull/1580#issuecomment-1588448382
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1580](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1580?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6064437) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/70cadef599571835f21ca671b17441199de805a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (70cadef) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 45.43% 45.56% +0.14%
==========================================
Files 158 158
Lines 9830 9830
Branches 968 968
==========================================
+ Hits 4465 4478 +13
+ Misses 5064 5054 -10
+ Partials 301 298 -3
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1580/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1580:
URL: https://github.com/apache/incubator-celeborn/pull/1580#discussion_r1227472197
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -334,6 +334,18 @@ private[celeborn] class Master(
context,
handleReportNodeUnavailable(context, failedWorkers, requestId))
+ case pb: PbWorkerLost =>
+ val host = pb.getHost
+ val rpcPort = pb.getRpcPort
+ val pushPort = pb.getPushPort
+ val fetchPort = pb.getFetchPort
+ val replicatePort = pb.getReplicatePort
+ val requestId = pb.getRequestId
+ logInfo(s"Received worker lost $host:$rpcPort:$pushPort:$fetchPort.")
Review Comment:
> replicate port?
refined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1580: [CELEBORN-668] Report WorkerLost instead of WorkerUnavailable if grac…
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1580:
URL: https://github.com/apache/incubator-celeborn/pull/1580#discussion_r1227464108
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -334,6 +334,18 @@ private[celeborn] class Master(
context,
handleReportNodeUnavailable(context, failedWorkers, requestId))
+ case pb: PbWorkerLost =>
+ val host = pb.getHost
+ val rpcPort = pb.getRpcPort
+ val pushPort = pb.getPushPort
+ val fetchPort = pb.getFetchPort
+ val replicatePort = pb.getReplicatePort
+ val requestId = pb.getRequestId
+ logInfo(s"Received worker lost $host:$rpcPort:$pushPort:$fetchPort.")
Review Comment:
replicate port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org