You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/05 02:18:50 UTC
[GitHub] [incubator-doris] dixingxing0 opened a new issue #6382: Improve metrics API of FE
dixingxing0 opened a new issue #6382:
URL: https://github.com/apache/incubator-doris/issues/6382
Currently FE's metrics API (http://fe_host:fe_port/metrics) return metrics like this:
```
...
# HELP doris_fe_job job statistics
# TYPE doris_fe_job gauge
doris_fe_job{job="load", type="HADOOP", state="UNKNOWN"} 0
# HELP doris_fe_job job statistics
# TYPE doris_fe_job gauge
doris_fe_job{job="load", type="HADOOP", state="PENDING"} 0
# HELP doris_fe_job job statistics
# TYPE doris_fe_job gauge
doris_fe_job{job="load", type="HADOOP", state="ETL"} 0
...
```
And we encountered an exception when using prometheus's [text-parser](https://github.com/prometheus/common/blob/8d1c9f84e3f78cb628a20f8e7be531c508237848/expfmt/text_parse.go#L496) to parse the metrics text:
```
text format parsing error in line 40: second HELP line for metric name "doris_fe_job"
```
I think doris should follow the format definition of prometheus and return metrics like this:
```
...
# HELP doris_fe_job job statistics
# TYPE doris_fe_job gauge
doris_fe_job{job="load", type="HADOOP", state="UNKNOWN"} 0
doris_fe_job{job="load", type="HADOOP", state="PENDING"} 0
doris_fe_job{job="load", type="HADOOP", state="ETL"} 0
...
```
I'll try to submit a PR to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #6382: Improve metrics API of FE
Posted by GitBox <gi...@apache.org>.
morningman closed issue #6382:
URL: https://github.com/apache/incubator-doris/issues/6382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org