You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jgill02 (via GitHub)" <gi...@apache.org> on 2023/05/22 04:32:46 UTC
[GitHub] [beam] jgill02 opened a new pull request, #26812: Jgill02 go avro null fix may21 2023
jgill02 opened a new pull request, #26812:
URL: https://github.com/apache/beam/pull/26812
Fixes [#26316](https://github.com/apache/beam/issues/26316).
In situations where there are nullable fields in an avro ocf file, previously a previous row's non-null value for a given column would be passed into a pcollection for a subsequent datum if that column was null.
Added a new test case to check for this, which failed using the previous logic.
Additionally, the previous avroio package was using a legacy version (2.1.0) which is ~3-4+ years old. Upgraded to the latest goavro/v2 version.
Amongst other bug fixes, this release of goavro is ~3-4x faster than the previous version (as documented on the goavro github [page](https://github.com/linkedin/goavro#major-improvements-in-v2-over-v1).)
I am not 100% sure if there are additional dependencies to the previous goavro package which I do not understand, in which case this PR can be scoped to solely the bug fix mentioned above as an alternative.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #26812: [GO SDK] - avroio null fix
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #26812:
URL: https://github.com/apache/beam/pull/26812#issuecomment-1573959751
Thanks John, that sounds good!
I'll merge once the checks pass. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #26812: [GO SDK] - avroio null fix
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #26812:
URL: https://github.com/apache/beam/pull/26812#issuecomment-1574073245
Failure not related to this PR. Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse merged pull request #26812: [GO SDK] - avroio null fix
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse merged PR #26812:
URL: https://github.com/apache/beam/pull/26812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26812: Jgill02 go avro null fix may21 2023
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26812:
URL: https://github.com/apache/beam/pull/26812#issuecomment-1556540171
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label go.
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jgill02 commented on pull request #26812: [GO SDK] - avroio null fix
Posted by "jgill02 (via GitHub)" <gi...@apache.org>.
jgill02 commented on PR #26812:
URL: https://github.com/apache/beam/pull/26812#issuecomment-1573927051
Hi Ritesh, thank you so much for your review. Regarding using a GCS bucket or something of that nature, I would certainly be happy to implement that, but just wanted to call out I was trying to replicate the existing set-up I saw (e.g. existing test case has a [tweet.avro](https://github.com/apache/beam/blob/master/sdks/go/data/tweet.avro) file added to the repo).
I could instead use a GCS location, but could use a suggestion on which public bucket to add it to so it will be persistent and available.
Thank you again for your review and help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26812: [GO SDK] - avroio null fix
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26812:
URL: https://github.com/apache/beam/pull/26812#issuecomment-1568328866
Reminder, please take a look at this pr: @riteshghorse @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #26812: [GO SDK] - avroio null fix
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #26812:
URL: https://github.com/apache/beam/pull/26812#issuecomment-1573960106
Run Go PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org