You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/18 12:12:49 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22952: Refactor ShardingSphereDataPersistService to split ShardingSphereTableDataPersistService and ShardingSphereTableRowDataPersistService
codecov-commenter commented on PR #22952:
URL: https://github.com/apache/shardingsphere/pull/22952#issuecomment-1356785308
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22952](https://codecov.io/gh/apache/shardingsphere/pull/22952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7fbb2f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aecfd44049d5765148ddbd496193b31b7a782a3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aecfd44) will **decrease** coverage by `0.01%`.
> The diff coverage is `11.86%`.
```diff
@@ Coverage Diff @@
## master #22952 +/- ##
============================================
- Coverage 49.64% 49.63% -0.02%
+ Complexity 2453 2452 -1
============================================
Files 4143 4145 +2
Lines 57822 57837 +15
Branches 9068 9067 -1
============================================
+ Hits 28705 28706 +1
- Misses 26593 26608 +15
+ Partials 2524 2523 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../schema/ShardingSphereTableDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3Qvc2VydmljZS9zY2hlbWEvU2hhcmRpbmdTcGhlcmVUYWJsZURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...hema/ShardingSphereTableRowDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3Qvc2VydmljZS9zY2hlbWEvU2hhcmRpbmdTcGhlcmVUYWJsZVJvd0RhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...er/ShardingSphereSchemaDataRegistrySubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvbWV0YWRhdGEvc3Vic2NyaWJlci9TaGFyZGluZ1NwaGVyZVNjaGVtYURhdGFSZWdpc3RyeVN1YnNjcmliZXIuamF2YQ==) | `33.33% <0.00%> (+2.08%)` | :arrow_up: |
| [...persist/data/ShardingSphereDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3QvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `9.80% <8.00%> (+4.63%)` | :arrow_up: |
| [...tabase/schema/builder/SystemSchemaBuilderRule.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvYnVpbGRlci9TeXN0ZW1TY2hlbWFCdWlsZGVyUnVsZS5qYXZh) | `87.80% <42.85%> (-9.50%)` | :arrow_down: |
| [.../manager/cluster/ClusterContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvQ2x1c3RlckNvbnRleHRNYW5hZ2VyQnVpbGRlci5qYXZh) | `83.33% <100.00%> (-1.05%)` | :arrow_down: |
| [...trics/prometheus/collector/BuildInfoCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL3R5cGUvcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9wcm9tZXRoZXVzL2NvbGxlY3Rvci9CdWlsZEluZm9Db2xsZWN0b3IuamF2YQ==) | `62.50% <0.00%> (ø)` | |
| [...ardingsphere/agent/metrics/api/MetricsWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvTWV0cmljc1dyYXBwZXIuamF2YQ==) | | |
| [...re/agent/metrics/api/advice/TransactionAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvYWR2aWNlL1RyYW5zYWN0aW9uQWR2aWNlLmphdmE=) | | |
| [...ngsphere/agent/metrics/api/constant/MetricIds.java](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvY29uc3RhbnQvTWV0cmljSWRzLmphdmE=) | | |
| ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/22952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org