You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Craig Russell <ap...@gmail.com> on 2017/12/30 20:17:28 UTC
A few problems with project/icla
I've pushed changes to the project/icla and have some issues I just cannot figure out:
1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
6. The Comment section would be nicer with a blue border.
Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
Thanks,
Craig
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few problems with project/icla
Posted by Sam Ruby <ru...@intertwingly.net>.
On Tue, Jan 2, 2018 at 12:57 AM, Craig Russell <ap...@gmail.com> wrote:
> TL;DR I am still looking for a simplified column of radio buttons.
>
> Thanks,
>
> Craig
>
>> On Dec 30, 2017, at 12:17 PM, Craig Russell <ap...@gmail.com> wrote:
>
>> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
> Still looking for a simplifying fix here.
The way to control layout is with CSS. The secretary workbench forces
each label within the doctype selection to be placed on their own line
with the following rule:
https://github.com/apache/whimsy/blob/f2d82c184c47fe6b0b6dd7a072b7567894b95cbd/www/secretary/workbench/public/secmail.css#L40
Search for 'block' here: https://www.w3schools.com/cssref/pr_class_display.asp
To do similarly within the form-check portion of the icla demo page,
you would do:
.form-check label {
display: block
}
- Sam Ruby
P.S. I've pushed a change that will force the browser to reload the
CSS definitions whenever it changes:
https://github.com/apache/whimsy/commit/a838bf4b4d4dbba4a2118ea81b4985a8539eeaff
If memory serves, without this change Safari in particular would often
serve this page from the cache without checking with the server. Even
on forced reloads.
Re: A few problems with project/icla
Posted by Craig Russell <ap...@gmail.com>.
TL;DR I am still looking for a simplified column of radio buttons.
Thanks,
Craig
> On Dec 30, 2017, at 12:17 PM, Craig Russell <ap...@gmail.com> wrote:
>
> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>
> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
Fixed.
@@ -99,7 +100,7 @@ class Invite < Vue
_li class: ('active' if @phase == :vote) do
_a 'Vote', onClick: self.selectVote
end
- _li class: ('active' if @phase = :invite) do <------------ OOPS
+ _li class: ('active' if @phase == :invite) do
_a 'Invite', onClick: self.selectInvite
end
end
> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
Fixed. See #1
> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
Fixed. See #1
> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
Still looking for a simplifying fix here.
> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
Fixed with
- _textarea name: 'voteComment', value: @voteComment, rows: 4,
- placeholder: 'Please vote on this candidate.',
- onChange: self.setVoteComment
+ _textarea.form_control rows: 4,
+ placeholder: 'Please discuss this candidate',
+ name: 'voteBody', value: @voteBody,
+ onChange: self.setVoteBody
> 6. The Comment section would be nicer with a blue border.
Fixed. See #5
>
> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>
> Thanks,
>
> Craig
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few problems with project/icla
Posted by Sam Ruby <ru...@intertwingly.net>.
Good catch!
- Sam Ruby
On Mon, Jan 1, 2018 at 2:31 PM, sebb <se...@gmail.com> wrote:
> On 1 January 2018 at 19:02, Sam Ruby <ru...@intertwingly.net> wrote:
>
>>
>>
>> On Mon, Jan 1, 2018 at 12:38 PM, Craig Russell <ap...@gmail.com>
>> wrote:
>>
>>>
>>> On Jan 1, 2018, at 9:34 AM, Craig Russell <ap...@gmail.com> wrote:
>>>
>>> That gives me a tiny three row box. Width 18 characters.
>>>
>>>
>> TL;DR: try _textarea.form_control rows: 4
>>
>> Longer answer: if you want to change how textarea looks on your page, you
>> would use CSS. Specifically, something like this:
>>
>> textarea {
>> width: 100%
>> }
>>
>> But that would apply to all textareas on all pages, so you would probably
>> want to limit it. With CSS, you would do this with a class. So on your
>> page you would put:
>>
>> <textarea class="mywidetextarea" rows="4"></textarea>
>>
>> And in your css, you would put:
>>
>> textarea .mywidetextarea {
>> width: 100%
>> }
>>
>> But this is a common thing to do, and bootstrap is a package that includes
>> a lot of common CSS rules. See:
>>
>> https://getbootstrap.com/docs/4.0/components/forms/
>>
>> To take advantage of this, you would use the "form-control" class, thus:
>>
>> <textarea class="form_control" rows="4"></textarea>
>>
>
> Should that be "form-control", given that it is quoted ?
>
>
>>
>> The way you would do this with wunderbar is:
>>
>> _textarea class: "form_control", rows: 4
>>
>>
> Ditto?
>
>
>> Or use the shortcut:
>>
>> _textarea.form_control rows: 4
>>
>> Note the use of underscore instead of dash in the last example.
>>
>> - Sam Ruby
>>
>> Specifically:
>>>
>>> _div.form_group do
>>> _label "Contributor's name:", for: 'iclaname'
>>> _input.form_control.iclaname! placeholder: 'GivenName FamilyName',
>>> required: true, value: @iclaname
>>> end
>>> _textarea rows: 4 <===============================================
>>> _div.form_group do
>>> _label "Contributor's E-Mail address:", for: 'iclaemail'
>>> _input.form_control.iclaemail! type: 'email', required: true,
>>> placeholder: 'user@example.com', onChange: self.setIclaEmail,
>>> value: @iclaemail
>>> end
>>>
>>>
>>> Craig L Russell
>>> Secretary, Apache Software Foundation
>>> clr@apache.org http://db.apache.org/jdo
>>>
>>>
>>
Re: A few problems with project/icla
Posted by sebb <se...@gmail.com>.
On 1 January 2018 at 19:02, Sam Ruby <ru...@intertwingly.net> wrote:
>
>
> On Mon, Jan 1, 2018 at 12:38 PM, Craig Russell <ap...@gmail.com>
> wrote:
>
>>
>> On Jan 1, 2018, at 9:34 AM, Craig Russell <ap...@gmail.com> wrote:
>>
>> That gives me a tiny three row box. Width 18 characters.
>>
>>
> TL;DR: try _textarea.form_control rows: 4
>
> Longer answer: if you want to change how textarea looks on your page, you
> would use CSS. Specifically, something like this:
>
> textarea {
> width: 100%
> }
>
> But that would apply to all textareas on all pages, so you would probably
> want to limit it. With CSS, you would do this with a class. So on your
> page you would put:
>
> <textarea class="mywidetextarea" rows="4"></textarea>
>
> And in your css, you would put:
>
> textarea .mywidetextarea {
> width: 100%
> }
>
> But this is a common thing to do, and bootstrap is a package that includes
> a lot of common CSS rules. See:
>
> https://getbootstrap.com/docs/4.0/components/forms/
>
> To take advantage of this, you would use the "form-control" class, thus:
>
> <textarea class="form_control" rows="4"></textarea>
>
Should that be "form-control", given that it is quoted ?
>
> The way you would do this with wunderbar is:
>
> _textarea class: "form_control", rows: 4
>
>
Ditto?
> Or use the shortcut:
>
> _textarea.form_control rows: 4
>
> Note the use of underscore instead of dash in the last example.
>
> - Sam Ruby
>
> Specifically:
>>
>> _div.form_group do
>> _label "Contributor's name:", for: 'iclaname'
>> _input.form_control.iclaname! placeholder: 'GivenName FamilyName',
>> required: true, value: @iclaname
>> end
>> _textarea rows: 4 <===============================================
>> _div.form_group do
>> _label "Contributor's E-Mail address:", for: 'iclaemail'
>> _input.form_control.iclaemail! type: 'email', required: true,
>> placeholder: 'user@example.com', onChange: self.setIclaEmail,
>> value: @iclaemail
>> end
>>
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> clr@apache.org http://db.apache.org/jdo
>>
>>
>
Re: A few problems with project/icla
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Jan 1, 2018 at 2:17 PM, Craig Russell <ap...@gmail.com> wrote:
> Getting there.
>
> So why is there a difference between the two boxes?
>
> _div.form_group do
> _label "Contributor's name:", for: 'iclaname'
> _input.form_control.iclaname! placeholder: 'GivenName FamilyName',
> required: true, value: @iclaname
> end
> _textarea class: "form_control", rows: 4
>
Change the above line to use a dash instead of an underscore (form-control
vs form_control).
> _textarea.form_control rows: 4
>
> _div.form_group do
> _label "Contributor's E-Mail address:", for: 'iclaemail'
> _input.form_control.iclaemail! type: 'email', required: true,
> placeholder: 'user@example.com', onChange: self.setIclaEmail,
> value: @iclaemail
> end
>
> On Jan 1, 2018, at 11:02 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Jan 1, 2018, at 9:34 AM, Craig Russell <ap...@gmail.com> wrote:
>>>
>>> That gives me a tiny three row box. Width 18 characters.
>>>
>>>
>> TL;DR: try _textarea.form_control rows: 4
>>
>> Longer answer: if you want to change how textarea looks on your page, you
>> would use CSS. Specifically, something like this:
>>
>> textarea {
>> width: 100%
>> }
>>
>> But that would apply to all textareas on all pages, so you would probably
>> want to limit it. With CSS, you would do this with a class. So on your
>> page you would put:
>>
>> <textarea class="mywidetextarea" rows="4"></textarea>
>>
>> And in your css, you would put:
>>
>> textarea .mywidetextarea {
>> width: 100%
>> }
>>
>> But this is a common thing to do, and bootstrap is a package that
>> includes a lot of common CSS rules. See:
>>
>> https://getbootstrap.com/docs/4.0/components/forms/
>>
>> To take advantage of this, you would use the "form-control" class, thus:
>>
>> <textarea class="form_control" rows="4"></textarea>
>>
>> The way you would do this with wunderbar is:
>>
>> _textarea class: "form_control", rows: 4
>>
>> Or use the shortcut:
>>
>> _textarea.form_control rows: 4
>>
>> Note the use of underscore instead of dash in the last example.
>>
>> - Sam Ruby
>>
>> Specifically:
>>>
>>>
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
>
Re: A few problems with project/icla
Posted by Craig Russell <ap...@gmail.com>.
Getting there.
So why is there a difference between the two boxes?
_div.form_group do
_label "Contributor's name:", for: 'iclaname'
_input.form_control.iclaname! placeholder: 'GivenName FamilyName',
required: true, value: @iclaname
end
_textarea class: "form_control", rows: 4
_textarea.form_control rows: 4
_div.form_group do
_label "Contributor's E-Mail address:", for: 'iclaemail'
_input.form_control.iclaemail! type: 'email', required: true,
placeholder: 'user@example.com', onChange: self.setIclaEmail,
value: @iclaemail
end
> On Jan 1, 2018, at 11:02 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
>> On Jan 1, 2018, at 9:34 AM, Craig Russell <apache.clr@gmail.com <ma...@gmail.com>> wrote:
>>
>> That gives me a tiny three row box. Width 18 characters.
>
>
> TL;DR: try _textarea.form_control rows: 4
>
> Longer answer: if you want to change how textarea looks on your page, you would use CSS. Specifically, something like this:
>
> textarea {
> width: 100%
> }
>
> But that would apply to all textareas on all pages, so you would probably want to limit it. With CSS, you would do this with a class. So on your page you would put:
>
> <textarea class="mywidetextarea" rows="4"></textarea>
>
> And in your css, you would put:
>
> textarea .mywidetextarea {
> width: 100%
> }
>
> But this is a common thing to do, and bootstrap is a package that includes a lot of common CSS rules. See:
>
> https://getbootstrap.com/docs/4.0/components/forms/ <https://getbootstrap.com/docs/4.0/components/forms/>
>
> To take advantage of this, you would use the "form-control" class, thus:
>
> <textarea class="form_control" rows="4"></textarea>
>
> The way you would do this with wunderbar is:
>
> _textarea class: "form_control", rows: 4
>
> Or use the shortcut:
>
> _textarea.form_control rows: 4
>
> Note the use of underscore instead of dash in the last example.
>
> - Sam Ruby
>
> Specifically:
>
>
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org <ma...@apache.org> http://db.apache.org/jdo <http://db.apache.org/jdo>
Re: A few problems with project/icla
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Jan 1, 2018 at 12:38 PM, Craig Russell <ap...@gmail.com> wrote:
>
> On Jan 1, 2018, at 9:34 AM, Craig Russell <ap...@gmail.com> wrote:
>
> That gives me a tiny three row box. Width 18 characters.
>
>
TL;DR: try _textarea.form_control rows: 4
Longer answer: if you want to change how textarea looks on your page, you
would use CSS. Specifically, something like this:
textarea {
width: 100%
}
But that would apply to all textareas on all pages, so you would probably
want to limit it. With CSS, you would do this with a class. So on your
page you would put:
<textarea class="mywidetextarea" rows="4"></textarea>
And in your css, you would put:
textarea .mywidetextarea {
width: 100%
}
But this is a common thing to do, and bootstrap is a package that includes
a lot of common CSS rules. See:
https://getbootstrap.com/docs/4.0/components/forms/
To take advantage of this, you would use the "form-control" class, thus:
<textarea class="form_control" rows="4"></textarea>
The way you would do this with wunderbar is:
_textarea class: "form_control", rows: 4
Or use the shortcut:
_textarea.form_control rows: 4
Note the use of underscore instead of dash in the last example.
- Sam Ruby
Specifically:
>
> _div.form_group do
> _label "Contributor's name:", for: 'iclaname'
> _input.form_control.iclaname! placeholder: 'GivenName FamilyName',
> required: true, value: @iclaname
> end
> _textarea rows: 4 <===============================================
> _div.form_group do
> _label "Contributor's E-Mail address:", for: 'iclaemail'
> _input.form_control.iclaemail! type: 'email', required: true,
> placeholder: 'user@example.com', onChange: self.setIclaEmail,
> value: @iclaemail
> end
>
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
>
Re: A few problems with project/icla
Posted by Craig Russell <ap...@gmail.com>.
> On Jan 1, 2018, at 9:34 AM, Craig Russell <ap...@gmail.com> wrote:
>
> That gives me a tiny three row box. Width 18 characters.
Specifically:
_div.form_group do
_label "Contributor's name:", for: 'iclaname'
_input.form_control.iclaname! placeholder: 'GivenName FamilyName',
required: true, value: @iclaname
end
_textarea rows: 4 <===============================================
_div.form_group do
_label "Contributor's E-Mail address:", for: 'iclaemail'
_input.form_control.iclaemail! type: 'email', required: true,
placeholder: 'user@example.com', onChange: self.setIclaEmail,
value: @iclaemail
end
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few problems with project/icla
Posted by Craig Russell <ap...@gmail.com>.
> On Jan 1, 2018, at 9:18 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Mon, Jan 1, 2018 at 11:42 AM, Craig Russell <ap...@gmail.com> wrote:
>> Hi Shane,
>>
>>> On Dec 31, 2017, at 6:16 AM, Shane Curcuru <as...@shanecurcuru.org> wrote:
>>>
>>> Two suggestions, in case they help:
>>>
>>> - Review the Bootstrap documentation for forms, and google some other
>>> Bootstrap form examples. It took me a while to figure out how some of
>>> the Bootstrap CSS layout for controls works.
>>
>> I've tried a number of things to get a simple multiline input that spans the whole width of the window, to no effect. https://getbootstrap.com/docs/4.0/components/forms/#form-controls looks promising but I can't figure out how to map the textarea source to this:
>>
>> <div class="form-group">
>> <label for="exampleFormControlTextarea1">Example textarea</label>
>> <textarea class="form-control" id="exampleFormControlTextarea1" rows="3"></textarea>
>> </div>
>>
>> I've tried _div.form-group but how do I get the <textarea rows="3"> to be generated?
>
> _textarea rows: 3
That gives me a tiny three row box. Width 18 characters.
>
>> Do you know where the documentation lives for the mapping from the _p, _div.form_group, etc. to the <p>, <div class="form-group"> ?
>
> https://github.com/rubys/wunderbar#quick-start-html
>
>>> - A form example (in a simple CGI, not an app) with multiline text:
>>>
>>> https://whimsy.apache.org/committers/tm-report
>>>
>> I notice in your tm-report page you use _div.form_group for many of the fields but then switch to a completely different paradigm emit_input for multiline input. What is the reason for that?
>>
>> Thanks,
>>
>> Craig
>
> P.S. I'll try to get back to your original questions later today.
>
>>> Craig Russell wrote on 12/30/17 3:17 PM:
>>>> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>>>>
>>>> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
>>>> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
>>>> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
>>>> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
>>>> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
>>>> 6. The Comment section would be nicer with a blue border.
>>>>
>>>> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>>>>
>>>> Thanks,
>>>>
>>>> Craig
>>>>
>>>> Craig L Russell
>>>> Secretary, Apache Software Foundation
>>>> clr@apache.org http://db.apache.org/jdo
>>>>
>>>
>>>
>>> --
>>>
>>> - Shane
>>> https://www.apache.org/foundation/marks/resources
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> clr@apache.org http://db.apache.org/jdo
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few problems with project/icla
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Jan 1, 2018 at 11:42 AM, Craig Russell <ap...@gmail.com> wrote:
> Hi Shane,
>
>> On Dec 31, 2017, at 6:16 AM, Shane Curcuru <as...@shanecurcuru.org> wrote:
>>
>> Two suggestions, in case they help:
>>
>> - Review the Bootstrap documentation for forms, and google some other
>> Bootstrap form examples. It took me a while to figure out how some of
>> the Bootstrap CSS layout for controls works.
>
> I've tried a number of things to get a simple multiline input that spans the whole width of the window, to no effect. https://getbootstrap.com/docs/4.0/components/forms/#form-controls looks promising but I can't figure out how to map the textarea source to this:
>
> <div class="form-group">
> <label for="exampleFormControlTextarea1">Example textarea</label>
> <textarea class="form-control" id="exampleFormControlTextarea1" rows="3"></textarea>
> </div>
>
> I've tried _div.form-group but how do I get the <textarea rows="3"> to be generated?
_textarea rows: 3
> Do you know where the documentation lives for the mapping from the _p, _div.form_group, etc. to the <p>, <div class="form-group"> ?
https://github.com/rubys/wunderbar#quick-start-html
>> - A form example (in a simple CGI, not an app) with multiline text:
>>
>> https://whimsy.apache.org/committers/tm-report
>>
> I notice in your tm-report page you use _div.form_group for many of the fields but then switch to a completely different paradigm emit_input for multiline input. What is the reason for that?
>
> Thanks,
>
> Craig
P.S. I'll try to get back to your original questions later today.
>> Craig Russell wrote on 12/30/17 3:17 PM:
>>> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>>>
>>> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
>>> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
>>> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
>>> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
>>> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
>>> 6. The Comment section would be nicer with a blue border.
>>>
>>> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>>>
>>> Thanks,
>>>
>>> Craig
>>>
>>> Craig L Russell
>>> Secretary, Apache Software Foundation
>>> clr@apache.org http://db.apache.org/jdo
>>>
>>
>>
>> --
>>
>> - Shane
>> https://www.apache.org/foundation/marks/resources
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
Re: A few problems with project/icla
Posted by Craig Russell <ap...@gmail.com>.
Hi Shane,
> On Dec 31, 2017, at 6:16 AM, Shane Curcuru <as...@shanecurcuru.org> wrote:
>
> Two suggestions, in case they help:
>
> - Review the Bootstrap documentation for forms, and google some other
> Bootstrap form examples. It took me a while to figure out how some of
> the Bootstrap CSS layout for controls works.
I've tried a number of things to get a simple multiline input that spans the whole width of the window, to no effect. https://getbootstrap.com/docs/4.0/components/forms/#form-controls looks promising but I can't figure out how to map the textarea source to this:
<div class="form-group">
<label for="exampleFormControlTextarea1">Example textarea</label>
<textarea class="form-control" id="exampleFormControlTextarea1" rows="3"></textarea>
</div>
I've tried _div.form-group but how do I get the <textarea rows="3"> to be generated?
Do you know where the documentation lives for the mapping from the _p, _div.form_group, etc. to the <p>, <div class="form-group"> ?
> - A form example (in a simple CGI, not an app) with multiline text:
>
> https://whimsy.apache.org/committers/tm-report
>
I notice in your tm-report page you use _div.form_group for many of the fields but then switch to a completely different paradigm emit_input for multiline input. What is the reason for that?
Thanks,
Craig
>
> Craig Russell wrote on 12/30/17 3:17 PM:
>> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>>
>> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
>> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
>> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
>> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
>> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
>> 6. The Comment section would be nicer with a blue border.
>>
>> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>>
>> Thanks,
>>
>> Craig
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> clr@apache.org http://db.apache.org/jdo
>>
>
>
> --
>
> - Shane
> https://www.apache.org/foundation/marks/resources
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few problems with project/icla
Posted by Shane Curcuru <as...@shanecurcuru.org>.
Two suggestions, in case they help:
- Review the Bootstrap documentation for forms, and google some other
Bootstrap form examples. It took me a while to figure out how some of
the Bootstrap CSS layout for controls works.
- A form example (in a simple CGI, not an app) with multiline text:
https://whimsy.apache.org/committers/tm-report
Craig Russell wrote on 12/30/17 3:17 PM:
> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>
> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
> 6. The Comment section would be nicer with a blue border.
>
> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>
> Thanks,
>
> Craig
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
--
- Shane
https://www.apache.org/foundation/marks/resources
Re: A few problems with project/icla
Posted by Craig Russell <ap...@gmail.com>.
I didn't know if the scaffolding I put in was required, and the discuss and vote pages are not anywhere near ready. But I have pushed them so you can see the invite page where I've been working.
Craig
> On Dec 31, 2017, at 6:31 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> If I go to http://whimsy.local/project/icla, I get redirected to
> http://whimsy.local/project/icla/invite, and then see:
>
> #<Errno::ENOENT: No such file or
> directory @ rb_sysopen -
> /Users/rubys/git/whimsy/www/project/icla/views/pages/discuss>
>
> I see icla/views/pages.js.rb:require_relative "pages/discuss"; perhaps
> a file wasn't committed?
>
> ---
>
> A general comment on Vue: once a component is rendered, it will only
> be re-rendered if at least one of the data items referenced by that
> component changes. Once I can see the pages working, I should be able
> to make a more specific recommendation.
>
> - Sam Ruby
>
> On Sat, Dec 30, 2017 at 3:17 PM, Craig Russell <ap...@gmail.com> wrote:
>> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>>
>> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
>> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
>> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
>> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
>> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
>> 6. The Comment section would be nicer with a blue border.
>>
>> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>>
>> Thanks,
>>
>> Craig
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> clr@apache.org http://db.apache.org/jdo
>>
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: A few problems with project/icla
Posted by Sam Ruby <ru...@intertwingly.net>.
If I go to http://whimsy.local/project/icla, I get redirected to
http://whimsy.local/project/icla/invite, and then see:
#<Errno::ENOENT: No such file or
directory @ rb_sysopen -
/Users/rubys/git/whimsy/www/project/icla/views/pages/discuss>
I see icla/views/pages.js.rb:require_relative "pages/discuss"; perhaps
a file wasn't committed?
---
A general comment on Vue: once a component is rendered, it will only
be re-rendered if at least one of the data items referenced by that
component changes. Once I can see the pages working, I should be able
to make a more specific recommendation.
- Sam Ruby
On Sat, Dec 30, 2017 at 3:17 PM, Craig Russell <ap...@gmail.com> wrote:
> I've pushed changes to the project/icla and have some issues I just cannot figure out:
>
> 1. The discuss/vote/invite tab should default to discuss but instead defaults to invite but the display is for discuss.
> 2. The discuss/vote/invite tab responds to the mouse click by changing the form but doesn't change the discuss/vote/invite itself. It remains stuck on invite.
> 3. The preview buttons never display even though the @phase variable is set to discuss, vote, or invite.
> 4. The radio buttons are displayed vertically only because I added _p within them. I modeled these buttons after secretary/workbench selection which shows vertical but when I remove the _p the buttons are displayed horizontally all smooshed together.
> 5. The Comment section is a text area but I cannot figure out how to make the width/size/columns stretch all the way across. I modeled the Note section of secretary/workbench but can't make a regular text box work with multiple lines.
> 6. The Comment section would be nicer with a blue border.
>
> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>
> Thanks,
>
> Craig
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>