You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/13 20:57:36 UTC
[GitHub] [pulsar] juliohm1978 opened a new pull request #5859: [Issue
5858][helm chart] Provide better defaults for ingress tls and secretName
configuration.
juliohm1978 opened a new pull request #5859: [Issue 5858][helm chart] Provide better defaults for ingress tls and secretName configuration.
URL: https://github.com/apache/pulsar/pull/5859
Fixes #5858, provides better defaults for the Ingress object and allows TLS to be enabled with an empty secretName.
### Motivation
The current helm chart can create an Ingress with TLS, but it requires a secretName to be added. This is not an Ingress requirement and, in some cases, the ingress controller can provide a default certificate when the Ingress object does not declare one.
### Modifications
Modifications include `values.yaml` and `dashboard-ingress.yaml` to address the issue.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Anything that affects deployment: yes - Ingress deployment on Kubernetes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services