You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2022/02/19 16:53:00 UTC

[logging-log4j2] 01/02: Use System.arraycopy.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit b652d236b79e0a61a95e21b7c6966f5d713842c2
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Feb 19 11:52:30 2022 -0500

    Use System.arraycopy.
---
 .../org/apache/logging/log4j/core/filter/CompositeFilter.java    | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java
index 43a8c0d..b2c5651 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java
@@ -60,12 +60,9 @@ public final class CompositeFilter extends AbstractLifeCycle implements Iterable
             return this;
         }
         if (filter instanceof CompositeFilter) {
-            final int size = this.filters.length + ((CompositeFilter) filter).size();
-            final Filter[] copy = Arrays.copyOf(this.filters, size);
-            int index = this.filters.length;
-            for (final Filter currentFilter : ((CompositeFilter) filter).filters) {
-                copy[index++] = currentFilter;
-            }
+            final CompositeFilter compositeFilter = (CompositeFilter) filter;
+            final Filter[] copy = Arrays.copyOf(this.filters, this.filters.length + compositeFilter.size());
+            System.arraycopy(compositeFilter.filters, 0, copy, this.filters.length, compositeFilter.filters.length);
             return new CompositeFilter(copy);
         }
         final Filter[] copy = Arrays.copyOf(this.filters, this.filters.length + 1);