[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2358: CASSANDRA-18180 Fix bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17

["ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>]

ekaterinadimitrova2 commented on code in PR #2358:
URL: https://github.com/apache/cassandra/pull/2358#discussion_r1231584731


##########
build.xml:
##########
@@ -306,8 +306,15 @@
         <equals arg1="${ant.java.version}" arg2="17"/>
     </condition>
 
-    <!-- needed to compile org.apache.cassandra.utils.JMXServerUtils -->
-    <condition property="jdk11plus-javac-exports" value="--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED" else="">
+    <resources id="_jdk11plus_javac_export_args">
+      <!-- needed to compile org.apache.cassandra.utils.JMXServerUtils -->
+      <string>--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED</string>
+      <!-- needed to compile org.apache.cassandra.utils.memory.BufferPool -->
+      <string>--add-exports java.base/jdk.internal.ref=ALL-UNNAMED</string>
+      <string>--add-exports java.base/sun.nio.ch=ALL-UNNAMED</string>

Review Comment:
   @djatnieks We need those also added for IntellijIdea, like this - https://github.com/ekaterinadimitrova2/cassandra/commit/d5fa5ecca4b1fdab27e0002d31bbc581ab5523a8
   Please pull this commit. CC @adelapena, as he will also be reviewing, and he will need this one for the IDE. 
   
   In other news, I am still reviewing; I just wanted to ask for this one to be added for everyone's convenience :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org