You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "andrea-patricelli (via GitHub)" <gi...@apache.org> on 2026/09/01 10:45:54 UTC
[PR] [SYNCOPE-1993] provide support for enable auto registration parameter also in core module [syncope]
andrea-patricelli opened a new pull request, #1515:
URL: https://github.com/apache/syncope/pull/1515
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1993] provide support for enable auto registration parameter also in core module [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso merged PR #1515:
URL: https://github.com/apache/syncope/pull/1515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1993] provide support for enable auto registration parameter also in core module [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1515:
URL: https://github.com/apache/syncope/pull/1515#discussion_r3903320750
##########
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java:
##########
@@ -122,14 +123,16 @@ public TaskExecutorUnloader taskExecutorUnloader(final ListableBeanFactory beanF
@ConditionalOnMissingBean
@Bean
- public SyncopeCoreStart keymasterStart(final DomainHolder<?> domainHolder) {
- return new SyncopeCoreStart(domainHolder);
+ public SyncopeCoreStart keymasterStart(
+ final DomainHolder<?> domainHolder,
+ final KeymasterProperties keymasterProps) {
+ return new SyncopeCoreStart(domainHolder, keymasterProps.isEnableAutoRegistration());
}
@ConditionalOnMissingBean
@Bean
- public KeymasterStop keymasterStop(final DomainHolder<?> domainHolder) {
- return new SyncopeCoreStop(domainHolder);
+ public KeymasterStop keymasterStop(final DomainHolder<?> domainHolder, final KeymasterProperties keymasterProps) {
+ return new SyncopeCoreStop(domainHolder, keymasterProps);
Review Comment:
Why passing only `boolean` to `SyncopeCoreStart` constructor and the whole `KeymasterProperties` to `SyncopeCoreStop`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1993] provide support for enable auto registration parameter also in core module [syncope]
Posted by "andrea-patricelli (via GitHub)" <gi...@apache.org>.
andrea-patricelli commented on code in PR #1515:
URL: https://github.com/apache/syncope/pull/1515#discussion_r3903388426
##########
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java:
##########
@@ -122,14 +123,16 @@ public TaskExecutorUnloader taskExecutorUnloader(final ListableBeanFactory beanF
@ConditionalOnMissingBean
@Bean
- public SyncopeCoreStart keymasterStart(final DomainHolder<?> domainHolder) {
- return new SyncopeCoreStart(domainHolder);
+ public SyncopeCoreStart keymasterStart(
+ final DomainHolder<?> domainHolder,
+ final KeymasterProperties keymasterProps) {
+ return new SyncopeCoreStart(domainHolder, keymasterProps.isEnableAutoRegistration());
}
@ConditionalOnMissingBean
@Bean
- public KeymasterStop keymasterStop(final DomainHolder<?> domainHolder) {
- return new SyncopeCoreStop(domainHolder);
+ public KeymasterStop keymasterStop(final DomainHolder<?> domainHolder, final KeymasterProperties keymasterProps) {
+ return new SyncopeCoreStop(domainHolder, keymasterProps);
Review Comment:
This is nonsense, going to align
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org