You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2010/03/04 02:57:27 UTC

[jira] Created: (HADOOP-6613) RPC server should check for version mismatch first

RPC server should check for version mismatch first
--------------------------------------------------

                 Key: HADOOP-6613
                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
             Project: Hadoop Common
          Issue Type: Bug
          Components: ipc, security
            Reporter: Kan Zhang
            Assignee: Kan Zhang


Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-6613:
------------------------------

    Attachment: HADOOP-6613-Y20S-1.patch

a patch for YAHOO 0.20.S branch. not for commit to trunk. 

> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-6613:
------------------------------

    Attachment: c6613-01.patch

A trivial patch for trunk, which simply moves the version checking ahead of AuthMethod checking in the same block of code. No additional test needed.

> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: c6613-01.patch, HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-6613:
------------------------------

    Status: Patch Available  (was: Open)

> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: c6613-01.patch, HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6613:
--------------------------------

           Status: Resolved  (was: Patch Available)
    Fix Version/s: 0.22.0
       Resolution: Fixed

I just committed this patch (which was manually tested) to trunk. Thanks, Kan!

> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>             Fix For: 0.22.0
>
>         Attachments: c6613-01.patch, HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878253#action_12878253 ] 

Hudson commented on HADOOP-6613:
--------------------------------

Integrated in Hadoop-Common-trunk #364 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/364/])
    HADOOP-6613. Moves the RPC version check ahead of the AuthMethod check. Contributed by Kan Zhang.


> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>             Fix For: 0.22.0
>
>         Attachments: c6613-01.patch, HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841061#action_12841061 ] 

Hadoop QA commented on HADOOP-6613:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12437833/c6613-01.patch
  against trunk revision 918624.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/408/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/408/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/408/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/408/console

This message is automatically generated.

> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: c6613-01.patch, HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6613) RPC server should check for version mismatch first

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878159#action_12878159 ] 

Hudson commented on HADOOP-6613:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #300 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/300/])
    HADOOP-6613. Moves the RPC version check ahead of the AuthMethod check. Contributed by Kan Zhang.


> RPC server should check for version mismatch first
> --------------------------------------------------
>
>                 Key: HADOOP-6613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6613
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>             Fix For: 0.22.0
>
>         Attachments: c6613-01.patch, HADOOP-6613-Y20S-1.patch
>
>
> Currently AuthMethod is checked before Version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.