You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2022/01/13 23:25:05 UTC

[logging-log4j2] branch master updated: Add Javadoc, comment, and format nit.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git


The following commit(s) were added to refs/heads/master by this push:
     new 751e652  Add Javadoc, comment, and format nit.
751e652 is described below

commit 751e6528c7935fea72e15f1204b7d9b41df67812
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jan 13 18:20:35 2022 -0500

    Add Javadoc, comment, and format nit.
---
 .../org/apache/log4j/bridge/AppenderWrapper.java   | 24 +++++++++++++---------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderWrapper.java b/log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderWrapper.java
index eb39fe7..d26c878 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderWrapper.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderWrapper.java
@@ -18,8 +18,6 @@ package org.apache.log4j.bridge;
 
 import org.apache.log4j.Appender;
 import org.apache.log4j.Layout;
-import org.apache.log4j.helpers.AppenderAttachableImpl;
-import org.apache.log4j.spi.AppenderAttachable;
 import org.apache.log4j.spi.ErrorHandler;
 import org.apache.log4j.spi.Filter;
 import org.apache.log4j.spi.LoggingEvent;
@@ -27,23 +25,29 @@ import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.core.filter.AbstractFilterable;
 import org.apache.logging.log4j.status.StatusLogger;
 
-import java.util.ArrayList;
-import java.util.Enumeration;
-import java.util.List;
-
 /**
- * Holds a Log4j 2 Appender in an empty Log4j 1 Appender so it can be extracted when constructing the configuration.
+ * Wraps a Log4j 2 Appender in an empty Log4j 1 Appender so it can be extracted when constructing the configuration.
  * Allows a Log4j 1 Appender to reference a Log4j 2 Appender.
  */
-public class AppenderWrapper extends AppenderAttachableImpl implements Appender {
+public class AppenderWrapper implements Appender {
 
     private static final Logger LOGGER = StatusLogger.getLogger();
     private final org.apache.logging.log4j.core.Appender appender;
 
+    /**
+     * Constructs a new instance for a Core Appender.
+     *
+     * @param appender a Core Appender.
+     */
     public AppenderWrapper(org.apache.logging.log4j.core.Appender appender) {
         this.appender = appender;
     }
 
+    /**
+     * Gets the wrapped Core Appender.
+     *
+     * @return the wrapped Core Appender.
+     */
     public org.apache.logging.log4j.core.Appender getAppender() {
         return appender;
     }
@@ -68,7 +72,7 @@ public class AppenderWrapper extends AppenderAttachableImpl implements Appender
 
     @Override
     public void clearFilters() {
-
+        // noop
     }
 
     @Override
@@ -95,7 +99,7 @@ public class AppenderWrapper extends AppenderAttachableImpl implements Appender
 
     @Override
     public ErrorHandler getErrorHandler() {
-        return ((ErrorHandlerAdapter)appender.getHandler()).getHandler();
+        return ((ErrorHandlerAdapter) appender.getHandler()).getHandler();
     }
 
     @Override