[GitHub] [pinot] richardstartin commented on a change in pull request #7566: Parsing Support for FILTER Clauses

[GitBox <gi...@apache.org>]

richardstartin commented on a change in pull request #7566:
URL: https://github.com/apache/pinot/pull/7566#discussion_r727047059



##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##########
@@ -111,7 +111,7 @@ private ImmutableRoaringBitmap queryRangeBitmap(long min, long max, long columnM
     if (Long.compareUnsigned(max, columnMax) < 0) {
       RoaringBitmap lte = rangeBitmap.lte(max);
       if (Long.compareUnsigned(min, 0) > 0) {
-        return rangeBitmap.gte(min, lte).toMutableRoaringBitmap();

Review comment:
       If this is fixing something, it isn't a correct fix. Do you have a minimal reproducer for what this is trying to address?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org