You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Meetesh Karia (JIRA)" <ji...@apache.org> on 2008/02/20 10:27:43 UTC
[jira] Created: (WICKET-1361) Localizer doesn't honor style when
caching property lookups
Localizer doesn't honor style when caching property lookups
-----------------------------------------------------------
Key: WICKET-1361
URL: https://issues.apache.org/jira/browse/WICKET-1361
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.1
Reporter: Meetesh Karia
In Wicket 1.2.6, we created some properties files like:
Foo.properties
Foo_style1.properties
Foo_style2.properties
and used StringResourceModel to look up property values. This worked correctly as in 1.2.6, Localizer didn't cache the property lookups and respected the style. However, in 1.3, Localizer now caches the lookups but doesn't respect the style when creating the cache key (though it does append the locale to the end of the cache key).
The side-effects of this are that whatever style is in use when a property is first looked up, that property value will be returned for all subsequent lookups regardless of style.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1361) Localizer doesn't honor style when
caching property lookups
Posted by "Meetesh Karia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577041#action_12577041 ]
Meetesh Karia commented on WICKET-1361:
---------------------------------------
that's good to know. thanks for the information and we'll keep that in mind for migration.
> Localizer doesn't honor style when caching property lookups
> -----------------------------------------------------------
>
> Key: WICKET-1361
> URL: https://issues.apache.org/jira/browse/WICKET-1361
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Meetesh Karia
> Assignee: Igor Vaynberg
> Fix For: 1.3.2
>
>
> In Wicket 1.2.6, we created some properties files like:
> Foo.properties
> Foo_style1.properties
> Foo_style2.properties
> and used StringResourceModel to look up property values. This worked correctly as in 1.2.6, Localizer didn't cache the property lookups and respected the style. However, in 1.3, Localizer now caches the lookups but doesn't respect the style when creating the cache key (though it does append the locale to the end of the cache key).
> The side-effects of this are that whatever style is in use when a property is first looked up, that property value will be returned for all subsequent lookups regardless of style.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1361) Localizer doesn't honor style when
caching property lookups
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1361.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.2
Assignee: Igor Vaynberg
> Localizer doesn't honor style when caching property lookups
> -----------------------------------------------------------
>
> Key: WICKET-1361
> URL: https://issues.apache.org/jira/browse/WICKET-1361
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Meetesh Karia
> Assignee: Igor Vaynberg
> Fix For: 1.3.2
>
>
> In Wicket 1.2.6, we created some properties files like:
> Foo.properties
> Foo_style1.properties
> Foo_style2.properties
> and used StringResourceModel to look up property values. This worked correctly as in 1.2.6, Localizer didn't cache the property lookups and respected the style. However, in 1.3, Localizer now caches the lookups but doesn't respect the style when creating the cache key (though it does append the locale to the end of the cache key).
> The side-effects of this are that whatever style is in use when a property is first looked up, that property value will be returned for all subsequent lookups regardless of style.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1361) Localizer doesn't honor style when
caching property lookups
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577043#action_12577043 ]
Igor Vaynberg commented on WICKET-1361:
---------------------------------------
i commented out the localizer line for now, and added a todo for 1.4
> Localizer doesn't honor style when caching property lookups
> -----------------------------------------------------------
>
> Key: WICKET-1361
> URL: https://issues.apache.org/jira/browse/WICKET-1361
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Meetesh Karia
> Assignee: Igor Vaynberg
> Fix For: 1.3.2
>
>
> In Wicket 1.2.6, we created some properties files like:
> Foo.properties
> Foo_style1.properties
> Foo_style2.properties
> and used StringResourceModel to look up property values. This worked correctly as in 1.2.6, Localizer didn't cache the property lookups and respected the style. However, in 1.3, Localizer now caches the lookups but doesn't respect the style when creating the cache key (though it does append the locale to the end of the cache key).
> The side-effects of this are that whatever style is in use when a property is first looked up, that property value will be returned for all subsequent lookups regardless of style.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1361) Localizer doesn't honor style when
caching property lookups
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577039#action_12577039 ]
Igor Vaynberg commented on WICKET-1361:
---------------------------------------
for now it does, but in 1.4 it will be split out. we meant to do it in 1.3 but forgot.
> Localizer doesn't honor style when caching property lookups
> -----------------------------------------------------------
>
> Key: WICKET-1361
> URL: https://issues.apache.org/jira/browse/WICKET-1361
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Meetesh Karia
> Assignee: Igor Vaynberg
> Fix For: 1.3.2
>
>
> In Wicket 1.2.6, we created some properties files like:
> Foo.properties
> Foo_style1.properties
> Foo_style2.properties
> and used StringResourceModel to look up property values. This worked correctly as in 1.2.6, Localizer didn't cache the property lookups and respected the style. However, in 1.3, Localizer now caches the lookups but doesn't respect the style when creating the cache key (though it does append the locale to the end of the cache key).
> The side-effects of this are that whatever style is in use when a property is first looked up, that property value will be returned for all subsequent lookups regardless of style.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1361) Localizer doesn't honor style when
caching property lookups
Posted by "Meetesh Karia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576907#action_12576907 ]
Meetesh Karia commented on WICKET-1361:
---------------------------------------
Hi Igor,
You obviously know the code much better than I do, so please forgive me if this is not correct. But, it appears as though the variation is always returned along with the style in Component.getStyle() and that's a final method so no one can change it. In that case, including the variation explicitly in the cache key would be unnecessary, right?
Thanks,
Meetesh
> Localizer doesn't honor style when caching property lookups
> -----------------------------------------------------------
>
> Key: WICKET-1361
> URL: https://issues.apache.org/jira/browse/WICKET-1361
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Meetesh Karia
> Assignee: Igor Vaynberg
> Fix For: 1.3.2
>
>
> In Wicket 1.2.6, we created some properties files like:
> Foo.properties
> Foo_style1.properties
> Foo_style2.properties
> and used StringResourceModel to look up property values. This worked correctly as in 1.2.6, Localizer didn't cache the property lookups and respected the style. However, in 1.3, Localizer now caches the lookups but doesn't respect the style when creating the cache key (though it does append the locale to the end of the cache key).
> The side-effects of this are that whatever style is in use when a property is first looked up, that property value will be returned for all subsequent lookups regardless of style.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.