You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@googlemail.com> on 2010/03/10 23:12:08 UTC

New release

Hi,

I want to make a new release of Struts 2 project. The steps are as follow:
- release new OGNL version 3.0
- move Struts 2 archetypes inside Struts 2 main folder (as it was with XWork)
- make a release

We have 2 issues solved for OGNL (I'm checking one regarding
efficiency), 7 for XWork and 27 for Struts 2 (fixed for 2.1.9, 2.2.x,
2.2.0). I will try to do it during next week.


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
I'm planning to merge 2.1.9 to 2.2.0 in JIRA to make a clean up and
drop 2.1.9 from RoadMap, any doubts?


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
I registered a Wish to upload OGNL 3.0 to Maven Central repo, after
that I will be able to make a release.


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Dale Newfield <da...@newfield.org>.
Thanks for working on this, Łukasz!

-Dale


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
2010/3/16 Dale Newfield <da...@newfield.org>:
> 151 and 157 appear to have fixes in the issues...any chance we can
> incorporate them, too?

I don't know how to test them, without real test cases I will not
implement those changes!

I made used below test case for 151 and it went smoothly with and
without changes:

    public void testNestedASTOrExpressions() throws Exception {
        // given
        String expression = "'t1' + ('t2' || 't3')";
        OgnlContext context = new OgnlContext();

        // when
        Node value = Ognl.compileExpression(context, null, expression);

        // then
        assertEquals("t1t2", value.getValue(context, null));
    }

For 157 I tried below test case after implementing the change but it
throws java.lang.IllegalArgumentException: argument type mismatch

    public void testMethodWithoutVarargsParameters() throws Exception {
        // given
        String expression = "clear()";
        OgnlContext context = new OgnlContext();
        StringChild root = new StringChild();

        // when
        Node value = Ognl.compileExpression(context, root, expression);

        // then
        assertEquals("t1t2", value.getValue(context, root));
    }


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Dale Newfield <da...@newfield.org>.
Lukasz Lenart wrote:
> Andreas Joseph Krogh asked:
>> Can you post a link to changes in 3.0?
> 
> http://jira.opensymphony.com/secure/IssueNavigator.jspa?reset=true&pid=10090&fixfor=21770
> except 145 - I thing it's a work for future

151 and 157 appear to have fixes in the issues...any chance we can 
incorporate them, too?

-Dale

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
2010/3/16 Andreas Joseph Krogh <an...@officenet.no>:
> On Tuesday 16. March 2010 11.04.29 Lukasz Lenart wrote:
>> I made a new release of OGNL 3.0, right now I'm trying to push it into
>> central repo?
>
> Can you post a link to changes in 3.0?

http://jira.opensymphony.com/secure/IssueNavigator.jspa?reset=true&pid=10090&fixfor=21770

except 145 - I thing it's a work for future


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Andreas Joseph Krogh <an...@officenet.no>.
On Tuesday 16. March 2010 11.04.29 Lukasz Lenart wrote:
> I made a new release of OGNL 3.0, right now I'm trying to push it into
> central repo?

Can you post a link to changes in 3.0?

-- 
Andreas Joseph Krogh <an...@officenet.no>
Senior Software Developer / CTO
------------------------+---------------------------------------------+
OfficeNet AS            | The most difficult thing in the world is to |
Rosenholmveien 25       | know how to do a thing and to watch         |
1414 Trollåsen          | somebody else doing it wrong, without       |
NORWAY                  | comment.                                    |
                        |                                             |
Tlf:    +47 24 15 38 90 |                                             |
Fax:    +47 24 15 38 91 |                                             |
Mobile: +47 909  56 963 |                                             |
------------------------+---------------------------------------------+

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
I made a new release of OGNL 3.0, right now I'm trying to push it into
central repo?


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
I noticed that we have branches for 2.x and 2.1.x. Should I make a
branch for 2.2.x as well after releasing it or before?


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Lukasz Lenart <lu...@googlemail.com>.
2010/3/11 Haroon Rafique <ha...@utoronto.ca>:
> Any chance XW-737 can be fixed (patch available) and made part of the
> release?

Solved, thanks!


Regards
-- 
Łukasz
http://www.lenart.org.pl/
Kapituła Javarsovia 2010
http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Haroon Rafique <ha...@utoronto.ca>.
On Today at 11:12pm, LL=>Lukasz Lenart <lu...@googlemail.com> wrote:

LL> Hi,
LL> 
LL> I want to make a new release of Struts 2 project. The steps are as follow:
LL> - release new OGNL version 3.0
LL> - move Struts 2 archetypes inside Struts 2 main folder (as it was with XWork)
LL> - make a release
LL> 
LL> We have 2 issues solved for OGNL (I'm checking one regarding
LL> efficiency), 7 for XWork and 27 for Struts 2 (fixed for 2.1.9, 2.2.x,
LL> 2.2.0). I will try to do it during next week.
LL> 
LL> 
LL> Regards
LL> 

Hi Lukasz,

Any chance XW-737 can be fixed (patch available) and made part of the 
release?

Cheers,
--
Haroon Rafique
<ha...@utoronto.ca>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: New release

Posted by Wes Wannemacher <we...@wantii.com>.
will this be 2.1.9 or 2.2.0 ?

On Wed, Mar 10, 2010 at 5:12 PM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> Hi,
>
> I want to make a new release of Struts 2 project. The steps are as follow:
> - release new OGNL version 3.0
> - move Struts 2 archetypes inside Struts 2 main folder (as it was with XWork)
> - make a release
>
> We have 2 issues solved for OGNL (I'm checking one regarding
> efficiency), 7 for XWork and 27 for Struts 2 (fixed for 2.1.9, 2.2.x,
> 2.2.0). I will try to do it during next week.
>
>
> Regards
> --
> Łukasz
> http://www.lenart.org.pl/
> Kapituła Javarsovia 2010
> http://javarsovia.pl
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>



-- 
Wes Wannemacher

Head Engineer, WanTii, Inc.
Need Training? Struts, Spring, Maven, Tomcat...
Ask me for a quote!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org