You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "vividbaek (via GitHub)" <gi...@apache.org> on 2026/08/02 07:33:35 UTC

[PR] [ZEPPELIN-6477] Stop dumping stack trace on Groovy cancellation [zeppelin]

vividbaek opened a new pull request, #5364:
URL: https://github.com/apache/zeppelin/pull/5364

   ### What is this PR for?
   
     Remove the `Thread.dumpStack()` call from Groovy paragraph cancellation because it writes an unnecessary stack trace directly to stderr.
   
     The existing `t.interrupt()` call is preserved, so the paragraph cancellation behavior remains unchanged.
   
     ### What type of PR is it?
   
     Improvement
   
     ### Todos
   
     * [x] Remove the unnecessary stack dump
     * [x] Preserve the thread interruption behavior
     * [x] Run the Groovy module build and tests
   
     ### What is the Jira issue?
   
     https://issues.apache.org/jira/browse/ZEPPELIN-6477
   
     ### How should this be tested?
   
     ```bash
     ./mvnw test -pl groovy
   
     The build completed successfully.
   
     ### Screenshots (if appropriate)
   
     Not applicable.
   
     ### Questions:
   
     - Does the license files need to update? No
     - Is there breaking changes for older versions? No
     - Does this needs documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6477] Stop dumping stack trace on Groovy cancellation [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #5364:
URL: https://github.com/apache/zeppelin/pull/5364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6477] Stop dumping stack trace on Groovy cancellation [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5364:
URL: https://github.com/apache/zeppelin/pull/5364#issuecomment-5167591455

   Merged into master (30bb6a83).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org