You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by dlaboss <gi...@git.apache.org> on 2016/03/17 19:03:35 UTC
[GitHub] incubator-quarks pull request: [QUARKS-39] cleanup java warnings
GitHub user dlaboss opened a pull request:
https://github.com/apache/incubator-quarks/pull/23
[QUARKS-39] cleanup java warnings
note: SplitWithEnumSample imports auto-reorganized by eclipse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlaboss/incubator-quarks warnings-quarks-39
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit da1e7e9ba5e0def26481c071de4715aeb312a0ce
Author: Dale LaBossiere <dl...@us.ibm.com>
Date: 2016-03-17T18:02:10Z
cleanup java warnings
note: SplitWithEnumSample imports auto-reorganized by eclipse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-39] cleanup java warnings
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/23#discussion_r56550593
--- Diff: api/topology/src/test/java/quarks/test/topology/TStreamTest.java ---
@@ -292,6 +292,7 @@ public void testSplitWithNegativeOutputs() throws Exception {
private enum LogSeverityEnum {
ALERT(1), CRITICAL(2), ERROR(3), WARNING(4), NOTICE(5), INFO(6), DEBUG(7);
+ @SuppressWarnings("unused")
--- End diff --
@Cazen pls adjust this post merge if desired.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-39] cleanup java warnings
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-39] cleanup java warnings
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/23#discussion_r56641665
--- Diff: api/topology/src/test/java/quarks/test/topology/TStreamTest.java ---
@@ -292,6 +292,7 @@ public void testSplitWithNegativeOutputs() throws Exception {
private enum LogSeverityEnum {
ALERT(1), CRITICAL(2), ERROR(3), WARNING(4), NOTICE(5), INFO(6), DEBUG(7);
+ @SuppressWarnings("unused")
--- End diff --
@dlaboss +1 LGTM Thank you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request: [QUARKS-39] cleanup java warnings
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/23#discussion_r56551534
--- Diff: samples/topology/src/main/java/quarks/samples/topology/CombiningStreamsProcessingResults.java ---
@@ -63,6 +63,7 @@ public static void main(String[] args) throws Exception {
// Split the stream by blood pressure category
List<TStream<Map<String, Integer>>> categories = readings.split(6, new ToIntFunction<Map<String, Integer>>() {
+ private static final long serialVersionUID = 1L;
--- End diff --
@queeniema pls adjust this post merge if desired. You should be able to replace the `new` with a lambda fn and simplify things. e.g., something like
```
... readings.split(6, tuple -> {
if (tuple.get("Systolic") < 120 && ...
// Normal
return 0;
} else if ...
...
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---