You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/03 17:44:52 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

cmccabe commented on a change in pull request #10019:
URL: https://github.com/apache/kafka/pull/10019#discussion_r569617960



##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -936,7 +939,10 @@ class DynamicListenerConfig(server: KafkaServer) extends BrokerReconfigurable wi
     if (listenersAdded.nonEmpty)
       server.socketServer.addListeners(listenersAdded)
 
-    server.kafkaController.updateBrokerInfo(server.createBrokerInfo)
+    server match {
+      case kafkaServer: KafkaServer => kafkaServer.kafkaController.updateBrokerInfo(kafkaServer.createBrokerInfo)
+      case _ =>

Review comment:
       Can you log an error message here?  This something we will need to implement (re-registration on listener change) but we don't have time right now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org