[GitHub] [helix] parakhnr commented on a diff in pull request #2462: Enabling INFO level for helix logs for TestClusterStatusMonitorLifecycle integration test.

["parakhnr (via GitHub)" <gi...@apache.org>]

parakhnr commented on code in PR #2462:
URL: https://github.com/apache/helix/pull/2462#discussion_r1181903156


##########
helix-core/src/test/java/org/apache/helix/LogHelper.java:
##########
@@ -0,0 +1,26 @@
+package org.apache.helix;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.core.LoggerContext;
+import org.apache.logging.log4j.core.config.Configuration;
+import org.apache.logging.log4j.core.config.LoggerConfig;
+
+/**
+ * Helper class for Logging related stuff.
+ */
+public class LogHelper {

Review Comment:
   Hmmm I made a new class, just so that in future if anybody needs to enable the logs for the test, they can simply use this class rather than starting from scratch. So, should I make it private or keep the helper class? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org