[jira] Reopened: (OFBIZ-2978) gatewayMessage should be pgrMessage in savePaymentGatewayResponse of PaymentGatewayServices

["Abdullah Shaikh (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Abdullah Shaikh reopened OFBIZ-2978:
------------------------------------


The code calling the service savePaymentGatewayResponse is attempting to use it for saving both PaymentGatewayResponse and PaymentGatewayRespMsg, but it is only capable of handling the former.

The savePgr method, calls savePaymentGatewayResponse service, and is called from multiple places, this method expects 2 parameters, DispatchContext & GenericValue, but the issue is the calling code which calls savePgr method passes PaymentGatewayResponse in some places and PaymentGatewayRespMsg in some places.

> gatewayMessage should be pgrMessage in savePaymentGatewayResponse of PaymentGatewayServices
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2978
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Abdullah Shaikh
>            Assignee: Scott Gray
>         Attachments: OFBIZ-2978_gatewayMessage should be pgrMessage.patch
>
>
> In savePaymentGatewayResponse method of PaymentGatewayServices class, we are setting the "gatewayMessage" field on the GenericValue of PaymentGatewayRespMsg, but there is no field named "gatewayMessage" in entity PaymentGatewayRespMsg but instead we need to use "pgrMessage" in place of "gatewayMessage".
> I guess we mistakely assumed the GenericValue which we get from the context, context.get("paymentGatewayResponse");, to be of PaymentGatewayResponse, but its the GenericValue of PaymentGatewayRespMsg but while putting it on the context we named it as "paymentGatewayResponse".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.