[jira] [Resolved] (THRIFT-3843) integer issues with Haxe PHP targets cause ZigZag encoding to fail

["Jens Geyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-3843.
--------------------------------
       Resolution: Fixed
         Assignee: Jens Geyer
    Fix Version/s: 0.10.0

Committed.

> integer issues with Haxe PHP targets cause ZigZag encoding to fail
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3843
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3843
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.10.0
>
>         Attachments: 0001-THRIFT-3843-integer-issues-with-Haxe-PHP-targets-cau.patch
>
>
> With PHP, the integer literal 0x80000000 is stored as a double, not an integer, unless PHP is forced into the latter. Due to the way how Haxe transpiles equality comparison into PHP Code, the result of comparing a variable holding this specific value against another variable or a literal may yield unexpected results.
> Another issue exists regarding incorrect code Generation for Haxe {{cast(...)}} statements w/regard to PHP targets.
> Technical details of the issues are available here:
>  * https://github.com/HaxeFoundation/haxe/issues/5288
>  * https://github.com/HaxeFoundation/haxe/issues/5289



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)