[jira] [Commented] (CAMEL-25875) camel-milo - a sessionTimeout configured on the component does not reach its endpoints

["Claus Ibsen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130578#comment-18130578 ] 

Claus Ibsen commented on CAMEL-25875:
-------------------------------------

Merged to main via https://github.com/apache/camel/pull/28252 (commit aaf0369de0ee).

> camel-milo - a sessionTimeout configured on the component does not reach its endpoints
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-25875
>                 URL: https://issues.apache.org/jira/browse/CAMEL-25875
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-milo
>    Affects Versions: 4.23.0
>            Reporter: Serdar Gökay
>            Assignee: Serdar Gökay
>            Priority: Minor
>             Fix For: 4.24.0
>
>
> {{MiloClientComponent}} and {{MiloBrowseComponent}} create the configuration of each endpoint with the copy constructor {{MiloClientConfiguration(MiloClientConfiguration other)}}. That constructor copies every option except {{sessionTimeout}} (since the initial import of the component). A session timeout configured on the component, for example with {{camel.component.milo-client.configuration.session-timeout}} or {{getConfiguration().setSessionTimeout(...)}}, therefore never reaches an endpoint, and Milo's default of 120 000 ms applies. The endpoint option {{sessionTimeout}} works, because the URI parameters are set on the copy.
> Fix: copy {{sessionTimeout}} in the copy constructor, with a test that a component-level session timeout reaches the endpoints of both components. I can provide the pull request.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)