[jira] [Commented] (FLINK-8690) Support distinct aggregation on group windowed streaming tables.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463759#comment-16463759 ] 

ASF GitHub Bot commented on FLINK-8690:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5940#discussion_r186033401
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala ---
    @@ -52,6 +52,76 @@ class SqlITCase extends StreamingWithStateTestBase {
         (8000L, "8", "Hello World"),
         (20000L, "20", "Hello World"))
     
    +  @Test
    +  def testDistinctAggWithMergeOnEventTimeSessionGroupWindow(): Unit = {
    +    // create a watermark with 10ms offset to delay the window emission by 10ms to verify merge
    +    val sessionWindowTestdata = List(
    +      (1L, 1, "Hello"),
    --- End diff --
    
    The test is not checking for DISTINCT semantics since all aggregated values are distinct. We could do `COUNT(DISTINCT num)` (`int` has to be renamed to `num` because its a SQL keyword).


> Support distinct aggregation on group windowed streaming tables.
> ----------------------------------------------------------------
>
>                 Key: FLINK-8690
>                 URL: https://issues.apache.org/jira/browse/FLINK-8690
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> Currently, *FlinkLogicalAggregate / FlinkLogicalWindowAggregate* does not allow distinct aggregate.
> We are proposing to reuse distinct aggregate codegen work designed for *FlinkLogicalOverAggregate*, to support unbounded distinct aggregation on datastream as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)