Re: [PR] [core] Generate changelog by copying data when records are insert-only [paimon]

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #3568:
URL: https://github.com/apache/paimon/pull/3568#discussion_r1650451478


##########
paimon-core/src/main/java/org/apache/paimon/table/AppendOnlyFileStoreTable.java:
##########
@@ -135,15 +138,18 @@ public RecordReader<InternalRow> reader(Split split) throws IOException {
 
     @Override
     public TableWriteImpl<InternalRow> newWrite(String commitUser) {
-        return newWrite(commitUser, null);
+        return newWrite(commitUser, null, null);
     }
 
     @Override
     public TableWriteImpl<InternalRow> newWrite(
-            String commitUser, ManifestCacheFilter manifestFilter) {
+            String commitUser,
+            ManifestCacheFilter manifestFilter,
+            @Nullable RecordAttributeManager recordAttributeManager) {

Review Comment:
   I prefer adding a `TableWriteImpl.withWriteOnly(boolean writeOnly)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org